From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ferruh.yigit@intel.com> Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 52005235 for <dev@dpdk.org>; Mon, 17 Jul 2017 18:03:53 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jul 2017 09:03:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,375,1496127600"; d="scan'208";a="126086027" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.249.74.32]) ([10.249.74.32]) by orsmga005.jf.intel.com with ESMTP; 17 Jul 2017 09:03:48 -0700 To: Gaetan Rivet <gaetan.rivet@6wind.com>, dev@dpdk.org References: <cover.1500130634.git.gaetan.rivet@6wind.com> <db76677a92c44a91f68ea3609dcda6f8490b195f.1500130635.git.gaetan.rivet@6wind.com> From: Ferruh Yigit <ferruh.yigit@intel.com> Message-ID: <2230acd3-1119-22ab-5456-858d90e9f789@intel.com> Date: Mon, 17 Jul 2017 17:03:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <db76677a92c44a91f68ea3609dcda6f8490b195f.1500130635.git.gaetan.rivet@6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v10 06/11] net/failsafe: support flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 17 Jul 2017 16:03:54 -0000 On 7/15/2017 6:57 PM, Gaetan Rivet wrote: > Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com> > Acked-by: Olga Shern <olgas@mellanox.com> <...> > + > + flow = fs_flow_allocate(attr, patterns, actions); > + FOREACH_SUBDEV_ST(sdev, i, dev, DEV_ACTIVE) { > + flow->flows[i] = rte_flow_create(PORT_ID(sdev), > + attr, patterns, actions, error); Should SUB_ID(sdev) used here? And in related functions. flow->flows[SUB_ID(sdev)] = ... > + if (flow->flows[i] == NULL) { > + ERROR("Failed to create flow on sub_device %d", > + i); > + goto err; > + } <...>