From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
 [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 27ACA8036
 for <dev@dpdk.org>; Thu, 27 Nov 2014 19:02:22 +0100 (CET)
Received: by mail-wi0-f177.google.com with SMTP id l15so9090146wiw.4
 for <dev@dpdk.org>; Thu, 27 Nov 2014 10:02:22 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=0h8pHddYX8lvn5ki1aCv8o0zUu05hS9aKsL9pq+1pbU=;
 b=YvcC+VSBVv7vs9IjP9akl3p/SJCoMolUqpnWCDeLGvDyJR7oAYqt0f4TS7NpNVYQgZ
 SEg/+2F+HSfgMHbYs4MmakL0cdZmEqRPdY9nrzCmWXjVNsX70sRkfFgJSpu5D6jHCvDN
 E1Z3nphAI+FO/4N5m9bYNUD+LmxYUcsbWAwH9o/ukVlHOlDAm6Ppfb1+JLlsaEhLIVht
 Ywx/Vr15qdoTZESdwXLOYpPx1SMrioRrCPedzQWkpMo0zc4XiCZUPOngkncgZIpkQMFh
 HunGHtdCZa/kkdXSCQKA6lae/71mtrlULJfdMwRXtPrKz3uGC0q/qfRNQEYb0/g5YZYL
 VQHg==
X-Gm-Message-State: ALoCoQmnyawrFSqLp38Fn+aiG/zQ1npQg35GZIm9btB+8xCcoZ5BirljbOpWrXqPvHp7ux6X4YoZ
X-Received: by 10.194.185.167 with SMTP id fd7mr62363065wjc.108.1417111342066; 
 Thu, 27 Nov 2014 10:02:22 -0800 (PST)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id r10sm12583711wiy.19.2014.11.27.10.02.20
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 27 Nov 2014 10:02:21 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Sujith Sankar <ssujith@cisco.com>
Date: Thu, 27 Nov 2014 19:01:58 +0100
Message-ID: <2232586.GRrg2Bq1yj@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; )
In-Reply-To: <1417108480-28341-1-git-send-email-ssujith@cisco.com>
References: <1417108480-28341-1-git-send-email-ssujith@cisco.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] enicpmd: compilation error during inclusion
	of vfio.h
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Nov 2014 18:02:22 -0000

2014-11-27 22:44, Sujith Sankar:
> Inclusion of vfio.h was giving compilation errors if kernel version is less
> than 3.6.0 and if RTE_EAL_VFIO was on in config.
> 
> Replaced inclusion of vfio.h with eal_vfio.h and replaced RTE_EAL_VFIO with
> VFIO_PRESENT in enicpmd code.

You should add
Reported-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>

> Signed-off-by: Sujith Sankar <ssujith@cisco.com>
[...]
>  CFLAGS += -I$(RTE_SDK)/lib/librte_hash/ -I$(RTE_SDK)/lib/librte_pmd_enic/vnic/
>  CFLAGS += -I$(RTE_SDK)/lib/librte_pmd_enic/
> +CFLAGS += -I$(RTE_SDK)/lib/librte_eal/linuxapp/eal/
>  CFLAGS += -O3 -Wno-deprecated

I think -I$(RTE_SDK)/lib/librte_hash/ and -I$(RTE_SDK)/lib/librte_eal/linuxapp/eal/
are not needed.

I'll fix it if you confirm.

-- 
Thomas