From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77BA5A0562; Tue, 4 May 2021 17:50:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BA8E94067E; Tue, 4 May 2021 17:50:28 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id A784F40147; Tue, 4 May 2021 17:50:26 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 5E7B65C01D2; Tue, 4 May 2021 11:50:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 04 May 2021 11:50:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= Y9zG4geNxaTUFb8EnS1UPfONF/ZNaXVBpiB43f4Q534=; b=1Ft05yZ3qKJiR2WJ Gw8DrfFFplm3+AEgrYtMeRn+iLkukbXLaPgBI60+hlmDw7JtAv0HKJN6TmuYKJH0 0pDxVtA8H/xXpelMLC34fmJCG8KjEgpwiMBOsfaQNFm7CBOo6Y2878FVQKqJcyyr XiJDRrBvSZA9jy0+nmwyzoP7n/XGPksRDhdwswxaZwf991sNf6xcHIF84cn8Pvej m1RWpvf3aM7GSNLcIXv0Jb4RcrOtM9c9a9takmvZaNBoUkpxerO268yGrwZyHvGC I3O+yIhKEeAxddIDVH4TgOgpp/J9KxEqQe9JDZl14r8xNACCC5gbTedIeHlm585P zG0cUA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Y9zG4geNxaTUFb8EnS1UPfONF/ZNaXVBpiB43f4Q5 34=; b=V15yqYmuv3BnSvEiz1YLU0dTCTAzDyW3QcDFuiQ8RKQArTI3dOXNvDoNU yhDL7m8YXfnf+BG5U/dPxVHz1Mgn0XZsMNn/HCjUQ1xSJhnZlK2/gxc348L+NEPq XTF8Rwdyqd1iPiyM3uvxZpLGFybQCYce/GUBVF99O7abazQLCFFsQAMn4KI6ZUWA g8gLpVsxHwOC0WBeUfyBDpbjL+13naakXFzaJlSufFFwxm9Pi6v/Q0P/uuZyzY/j NbnGmnsVg+zk3Ex/5ZLvTYzYmbofadhittZFNeJe6wR+WVjI2qgQlnNEAWrXM9Vf ip9V0uQXUWeKpcBTAqnHzGXmsMFyw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdefiedgleeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 4 May 2021 11:50:23 -0400 (EDT) From: Thomas Monjalon To: hemant.agrawal@nxp.com, Ferruh Yigit Cc: dev@dpdk.org, stable@dpdk.org, stephen@networkplumber.org, longli@microsoft.com, Rosen Xu Date: Tue, 04 May 2021 17:50:22 +0200 Message-ID: <2232862.pp3s5jRlb4@thomas> In-Reply-To: References: <20210429055548.12964-1-hemant.agrawal@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] ethdev: add missing buses in dev iterator X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/05/2021 14:49, Ferruh Yigit: > On 4/29/2021 9:01 AM, Hemant Agrawal wrote: > > > > On 4/29/2021 1:26 PM, Thomas Monjalon wrote: > >> 29/04/2021 07:55, Hemant Agrawal: > >>> This patch fixes issue with OVS 2.15 not working on > >>> DPAA/FSLMC based platform due to missing support for > >>> these busses in dev_iterate. > >>> This patch adds dpaa_bus and fslmc to dev iterator > >>> for bus arguments. > >> I think we should add VMBus as well. > > They are 2 buses remaining vmbus and ifpga. However I don't know, if they use > > args as vdev or as pci? > > cc Rosen for the 'ifpga' bus, 'vmbus' maintainer seems already cc'ed. > > This variable ('bus_param_key') is used to construct 'bus_str', and 'bus_str' > seems used only for the '.dev_iterate' bus operation. > > Since 'ifpga' & 'vmbus' are not implementing the '.dev_iterate', so is it really > required to add them? Good point Ferruh. The only bus implementing dev_iterate are dpaa, fslmc, pci and vdev. So this patch makes sense. Acked-by: Thomas Monjalon