From: Thomas Monjalon <thomas@monjalon.net>
To: Qi Zhang <qi.z.zhang@intel.com>
Cc: dev@dpdk.org, Remy Horton <remy.horton@intel.com>
Subject: Re: [dpdk-dev] [PATCH] ethtool: disable promiscuous mode by default
Date: Fri, 21 Apr 2017 02:23:54 +0200 [thread overview]
Message-ID: <2233343.mu9cWWFKfO@xps> (raw)
In-Reply-To: <b975bd93-fc4c-fac8-f74e-fa03590426b6@intel.com>
18/04/2017 16:26, Remy Horton:
> Probably ought to also add a new command so that promiscuous mode can be
> enabled if needed.
>
> On 12/04/2017 20:58, Qi Zhang wrote:
> > Disable promiscuous mode by default since VLAN filter
> > does not work when promiscuous mode is enabled.
> >
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> > ---
> >
> > examples/ethtool/ethtool-app/main.c | 1 -
> > 1 file changed, 1 deletion(-)
>
> Acked-by: Remy Horton <remy.horton@intel.com>
Applied, thanks
prev parent reply other threads:[~2017-04-21 0:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 19:58 Qi Zhang
2017-04-18 14:26 ` Remy Horton
2017-04-21 0:23 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2233343.mu9cWWFKfO@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=remy.horton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).