From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3530B42D76; Wed, 28 Jun 2023 02:44:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B627A406B3; Wed, 28 Jun 2023 02:44:22 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 7E2FB40151 for ; Wed, 28 Jun 2023 02:44:21 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 447BF320079B; Tue, 27 Jun 2023 20:44:20 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 27 Jun 2023 20:44:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1687913059; x=1687999459; bh=5k+haA9LsQv8T0Sq7xM6v4ykiK7KBQFNjKv ZEzk0A8M=; b=TtcLY18fwBUjDjx6BIPV4JfC5Rz0y9jY0dsdbUt1a+ONuPZLrd7 oay3HoDUwPAnoByokDdhljcW+gVwV5ixwcOnm2sD/AemU7jCrTGx93gLZuNX1j2p kR2kDsMqDska6dJn41dL2tEA7fypG9RaM7eCMe44k1S6loDSXY3W498g9AeYntAa vBrIg7TYKjWzAJDbtM8BCoBXUUmzoOTzuQWNoHUpCo4XPuwxPkhyR+yEZB3HOWsp G2ZIdBo6ls/FZxzdHetBzbfxQHZFpfx7cco05DC0NX2e81W0OGkKK1kl236dGQ0I MrbluKyEL64e61xYXsXv92t2zGmIyNJCFIQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1687913059; x=1687999459; bh=5k+haA9LsQv8T0Sq7xM6v4ykiK7KBQFNjKv ZEzk0A8M=; b=KqAq/JxTZXouCzSLeu2D/9VhKRowoARfaGtr8XBX9KqHSW/UCmT EZy79Tq7coWDQ1aqSJtSHTFLajmmxHwqS+xq41FenCGGOFt//djLwhw60N88EFyw 4JlsCgzBdCim8Ip7Qoa3ByJ69WenFhUHhui5C2b3rNd+qHYeBZI2NQnt2DZJO7Ao byGkk2oYl5RZonPI3tQb0s0aBN4Y2gSunBxD3HOaVspdTEu4k/cWcPhOk5MIqjlM bYACcusFWhKyGMro6vbveBGZuylEr6uxZg2n2IP4S92xdTuP+qpNNsc5t62QyT3I 1bVoFmeI9CmcqJsCXWAkFmosnHLR9RdIEcw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrtddugdeflecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 27 Jun 2023 20:44:18 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger , prateekag@cse.iitb.ac.in Cc: dev@dpdk.org, Tyler Retzlaff Subject: Re: [PATCH] app: do not call printf in signal handlers Date: Wed, 28 Jun 2023 02:44:09 +0200 Message-ID: <2234390.KTMopqUuYO@thomas> In-Reply-To: <20230615201404.GB32486@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20201204175151.11868-1-pratekag@gmail.com> <20230613001150.65407-1-stephen@networkplumber.org> <20230615201404.GB32486@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 15/06/2023 22:14, Tyler Retzlaff: > On Mon, Jun 12, 2023 at 05:11:50PM -0700, Stephen Hemminger wrote: > > Using printf is not async-signal safe and worst case may lead to deadlock. > > Remove printf from signal handlers present in several applications. > > > > Testpmd was already fixed by > > commit 0fd1386c30c3 ("app/testpmd: cleanup cleanly from signal") > > > > Signed-off-by: Prateek Agarwal > > Signed-off-by: Stephen Hemminger > > --- > > Acked-by: Tyler Retzlaff Applied, thanks for reviving this old patch.