* [dpdk-dev] [PATCH] app/testpmd: fix wrong cmdline message
@ 2017-08-03 9:45 Jiayu Hu
2017-08-03 11:11 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Jiayu Hu @ 2017-08-03 9:45 UTC (permalink / raw)
To: dev; +Cc: jingjing.wu, Jiayu Hu
In testpmd, GRO is supported by csum forwarding engine, but the cmdline
message shows GRO is supported by io forwarding engine. This patch is
to fix this issue.
Fixes: b40f8d782ba1 ("app/testpmd: enable TCP/IPv4 GRO")
Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
---
app/test-pmd/cmdline.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index b1b36c1..cd8c358 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -424,8 +424,8 @@ static void cmd_help_long_parsed(void *parsed_result,
" Display the status of TCP Segmentation Offload.\n\n"
"gro (on|off) (port_id)"
- " Enable or disable Generic Receive Offload in io"
- " forward engine.\n\n"
+ " Enable or disable Generic Receive Offload in"
+ " csum forwarding engine.\n\n"
"gro set (max_flow_num) (max_item_num_per_flow) (port_id)\n"
" Set max flow number and max packet number per-flow"
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] app/testpmd: fix wrong cmdline message
2017-08-03 9:45 [dpdk-dev] [PATCH] app/testpmd: fix wrong cmdline message Jiayu Hu
@ 2017-08-03 11:11 ` Ferruh Yigit
2017-08-03 21:39 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2017-08-03 11:11 UTC (permalink / raw)
To: Jiayu Hu, dev; +Cc: jingjing.wu
On 8/3/2017 10:45 AM, Jiayu Hu wrote:
> In testpmd, GRO is supported by csum forwarding engine, but the cmdline
> message shows GRO is supported by io forwarding engine. This patch is
> to fix this issue.
>
> Fixes: b40f8d782ba1 ("app/testpmd: enable TCP/IPv4 GRO")
>
> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] app/testpmd: fix wrong cmdline message
2017-08-03 11:11 ` Ferruh Yigit
@ 2017-08-03 21:39 ` Thomas Monjalon
2017-08-04 0:53 ` Hu, Jiayu
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2017-08-03 21:39 UTC (permalink / raw)
To: Jiayu Hu; +Cc: dev, Ferruh Yigit, jingjing.wu
03/08/2017 13:11, Ferruh Yigit:
> On 8/3/2017 10:45 AM, Jiayu Hu wrote:
> > In testpmd, GRO is supported by csum forwarding engine, but the cmdline
> > message shows GRO is supported by io forwarding engine. This patch is
> > to fix this issue.
> >
> > Fixes: b40f8d782ba1 ("app/testpmd: enable TCP/IPv4 GRO")
> >
> > Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
More precise title:
app/testpmd: fix GRO command description
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] app/testpmd: fix wrong cmdline message
2017-08-03 21:39 ` Thomas Monjalon
@ 2017-08-04 0:53 ` Hu, Jiayu
0 siblings, 0 replies; 4+ messages in thread
From: Hu, Jiayu @ 2017-08-04 0:53 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, Yigit, Ferruh, Wu, Jingjing
Hi Thomas,
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Friday, August 4, 2017 5:40 AM
> To: Hu, Jiayu <jiayu.hu@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix wrong cmdline message
>
> 03/08/2017 13:11, Ferruh Yigit:
> > On 8/3/2017 10:45 AM, Jiayu Hu wrote:
> > > In testpmd, GRO is supported by csum forwarding engine, but the cmdline
> > > message shows GRO is supported by io forwarding engine. This patch is
> > > to fix this issue.
> > >
> > > Fixes: b40f8d782ba1 ("app/testpmd: enable TCP/IPv4 GRO")
> > >
> > > Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> >
> > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Applied, thanks
>
> More precise title:
> app/testpmd: fix GRO command description
Thanks a lot and I will choose a good title next time.
BRs,
Jiayu
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-04 0:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-03 9:45 [dpdk-dev] [PATCH] app/testpmd: fix wrong cmdline message Jiayu Hu
2017-08-03 11:11 ` Ferruh Yigit
2017-08-03 21:39 ` Thomas Monjalon
2017-08-04 0:53 ` Hu, Jiayu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).