From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C646545619; Fri, 12 Jul 2024 19:55:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B50C440661; Fri, 12 Jul 2024 19:55:32 +0200 (CEST) Received: from fhigh4-smtp.messagingengine.com (fhigh4-smtp.messagingengine.com [103.168.172.155]) by mails.dpdk.org (Postfix) with ESMTP id A4A834065A for ; Fri, 12 Jul 2024 19:55:30 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 193D01140C46; Fri, 12 Jul 2024 13:55:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Fri, 12 Jul 2024 13:55:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1720806930; x=1720893330; bh=NvUZ1h8rrEKTG0G7y/s3Lt5mH1MwqDhRkr2hFTK+E64=; b= cgpfpJO5zAOvng6OiyXbBLu6Js5coMgOG8acmXkKNxMhdKEbeiQxJyjB5GFhCr7H Ixr/UbVZYpqG5Q6P61ZjTeGU0boxaDf+QwiqYSLVmiGiTkeaXW5bBOixXG8sKWb1 9pmv9aEP0sp15KHYiiJA1PcDN4aPZNVdL+B2mXq+OcPsdyH0ybVMTjeeIMD5IFdF zFs/RxbTixF0tZ6+GS6+wvRpbkVJqpzJBLqoHJ0k40v3bPaKLpTB0hoaaeX8+em0 YpYJgl/sVeCHXFBOrhwqf8TEyoE8L22Kn4FFKR2WWMF1514igLkhG+DDTnjuBQ6b gP14NOTs8JjpXMv89s3jjQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1720806930; x= 1720893330; bh=NvUZ1h8rrEKTG0G7y/s3Lt5mH1MwqDhRkr2hFTK+E64=; b=D cl4NGSHA/Drj0qijDkAjCSbRgCQvgUPW2jEyMj1McqA9J+UcpUVTy8griGwVfpiy RTs+Cs3r2aceDi148KkmgKXwwu0rt8IARyXN6JwqIt5IWR7uga76afK54ZqS/Q6y l9OdbQdE3Ml2IQVNXRQrN8TQAC+aUtXgAZ6SNIWeTWhDY4DZxGik8/yJ0r6gmfNa N8X6Pmk7pQNVhL1RNp+hudYL0ovVQZnzxa6b3tdvCRuKmATHBKAUpVgAD5r4ONnI lMBBO8iET0MybGGh1xb3Gd+IaMy4uefzOa9hkQrTreVX1viDBOF0DLwUfst/rEn4 uWx6AatZkgddddU6/W2kA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrfeeigdduudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeegtddtleejjeegffekkeektdejvedtheevtdekiedvueeuvdei uddvleevjeeujeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 12 Jul 2024 13:55:24 -0400 (EDT) From: Thomas Monjalon To: Shani Peretz , David Marchand Cc: dev@dpdk.org, chenbox@nvidia.com, dev@dpdk.org, dsosnowski@nvidia.com, jblunck@infradead.org, mkashani@nvidia.com, nipun.gupta@amd.com, roretzla@linux.microsoft.com Subject: Re: [PATCH v3] eal/common: fix inconsistent representation of PCI numbers Date: Fri, 12 Jul 2024 19:55:18 +0200 Message-ID: <22351303.EfDdHjke4D@thomas> In-Reply-To: References: <20240701200117.6349-1-shperetz@nvidia.com> <20240708165145.1405107-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 12/07/2024 15:49, David Marchand: > On Mon, Jul 8, 2024 at 6:52=E2=80=AFPM Shani Peretz = wrote: > > > > DPDK allows for two ways to specify PCI device numbers: > > a full version ("0000:08:00.0") and a short version ("08:00.0"). > > The problem arises when the application uses one format (e.g., full) > > when running testpmd, but then tries to use the other format (e.g., sho= rt) > > in a subsequent command, leading to a failure. > > > > The cmp_dev_name func, which is responsible for comparing PCI device na= mes, > > is not handling the inconsistent PCI number representations correctly. > > The suggested fix is to use the pci_parse function, which can parse > > the PCI device name and fill a struct rte_pci_addr with the standardized > > representation of the PCI number. > > By comparing the struct rte_pci_addr instances instead of the string > > representations, the application can ensure consistent handling of > > PCI device numbers, regardless of the format used. > > > > Fixes: a3ee360f4440 ("eal: add hotplug add/remove device") > > Cc: jblunck@infradead.org > > > > Signed-off-by: Shani Peretz > > Acked-by: Dariusz Sosnowski > > Acked-by: Thomas Monjalon >=20 > I find it strange that Thomas acked this patch (for example, the > commit title prefix is wrong). >=20 > I don't understand the issue. > Please provide a reproducer. > And ideally we need a unit test to track regressions on this topic. Indeed, Shani we shouldn't add "Acked-by" until all is reviewed in detail.