* [dpdk-dev] [PATCH] net/ixgbe: fix hierarchy commit check
@ 2017-07-26 14:54 Wenzhuo Lu
2017-07-26 15:17 ` Dumitrescu, Cristian
2017-07-26 15:20 ` Wiles, Keith
0 siblings, 2 replies; 5+ messages in thread
From: Wenzhuo Lu @ 2017-07-26 14:54 UTC (permalink / raw)
To: dev; +Cc: Wenzhuo Lu
If there's no Traffic Management node added,
not necessary to check if TM is committed.
Fixes: 5713ade69776 ("net/ixgbe: support committing TM hierarchy")
Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 194058f..e436dca 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -2693,7 +2693,7 @@ static int eth_ixgbevf_pci_remove(struct rte_pci_device *pci_dev)
ixgbe_l2_tunnel_conf(dev);
ixgbe_filter_restore(dev);
- if (!tm_conf->committed)
+ if (tm_conf->root && !tm_conf->committed)
PMD_DRV_LOG(WARNING,
"please call hierarchy_commit() "
"before starting the port");
--
1.9.3
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] net/ixgbe: fix hierarchy commit check
2017-07-26 14:54 [dpdk-dev] [PATCH] net/ixgbe: fix hierarchy commit check Wenzhuo Lu
@ 2017-07-26 15:17 ` Dumitrescu, Cristian
2017-07-31 16:53 ` Thomas Monjalon
2017-07-26 15:20 ` Wiles, Keith
1 sibling, 1 reply; 5+ messages in thread
From: Dumitrescu, Cristian @ 2017-07-26 15:17 UTC (permalink / raw)
To: Lu, Wenzhuo, dev; +Cc: Lu, Wenzhuo
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu
> Sent: Wednesday, July 26, 2017 3:54 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: [dpdk-dev] [PATCH] net/ixgbe: fix hierarchy commit check
>
> If there's no Traffic Management node added,
> not necessary to check if TM is committed.
>
> Fixes: 5713ade69776 ("net/ixgbe: support committing TM hierarchy")
>
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 194058f..e436dca 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -2693,7 +2693,7 @@ static int eth_ixgbevf_pci_remove(struct
> rte_pci_device *pci_dev)
> ixgbe_l2_tunnel_conf(dev);
> ixgbe_filter_restore(dev);
>
> - if (!tm_conf->committed)
> + if (tm_conf->root && !tm_conf->committed)
> PMD_DRV_LOG(WARNING,
> "please call hierarchy_commit() "
> "before starting the port");
> --
> 1.9.3
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] net/ixgbe: fix hierarchy commit check
2017-07-26 15:17 ` Dumitrescu, Cristian
@ 2017-07-31 16:53 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2017-07-31 16:53 UTC (permalink / raw)
To: Lu, Wenzhuo; +Cc: dev, Dumitrescu, Cristian
> > If there's no Traffic Management node added,
> > not necessary to check if TM is committed.
> >
> > Fixes: 5713ade69776 ("net/ixgbe: support committing TM hierarchy")
> >
> > Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
>
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Added TM in the title and applied, thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ixgbe: fix hierarchy commit check
2017-07-26 14:54 [dpdk-dev] [PATCH] net/ixgbe: fix hierarchy commit check Wenzhuo Lu
2017-07-26 15:17 ` Dumitrescu, Cristian
@ 2017-07-26 15:20 ` Wiles, Keith
2017-07-26 15:21 ` Wiles, Keith
1 sibling, 1 reply; 5+ messages in thread
From: Wiles, Keith @ 2017-07-26 15:20 UTC (permalink / raw)
To: Lu, Wenzhuo; +Cc: dev
> On Jul 26, 2017, at 9:54 AM, Wenzhuo Lu <wenzhuo.lu@intel.com> wrote:
>
> If there's no Traffic Management node added,
> not necessary to check if TM is committed.
>
> Fixes: 5713ade69776 ("net/ixgbe: support committing TM hierarchy")
>
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 194058f..e436dca 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -2693,7 +2693,7 @@ static int eth_ixgbevf_pci_remove(struct rte_pci_device *pci_dev)
> ixgbe_l2_tunnel_conf(dev);
> ixgbe_filter_restore(dev);
>
> - if (!tm_conf->committed)
> + if (tm_conf->root && !tm_conf->committed)
> PMD_DRV_LOG(WARNING,
> "please call hierarchy_commit() "
> "before starting the port”);
This patch may work on ixgbe, but I am using i40e and the message is still present. I tried to apply your logic above and that seemed to fix the i40e message.
Looks like you need to change all of the drivers that use this logic.
Here is the i40e change:
i40e_dev_start()
- if (!pf->tm_conf.committed)
+ if (pf->tm_conf.root && !pf->tm_conf.committed)
> --
> 1.9.3
>
Regards,
Keith
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] net/ixgbe: fix hierarchy commit check
2017-07-26 15:20 ` Wiles, Keith
@ 2017-07-26 15:21 ` Wiles, Keith
0 siblings, 0 replies; 5+ messages in thread
From: Wiles, Keith @ 2017-07-26 15:21 UTC (permalink / raw)
To: Lu, Wenzhuo; +Cc: dev
> On Jul 26, 2017, at 10:20 AM, Wiles, Keith <keith.wiles@intel.com> wrote:
>
>>
>> On Jul 26, 2017, at 9:54 AM, Wenzhuo Lu <wenzhuo.lu@intel.com> wrote:
>>
>> If there's no Traffic Management node added,
>> not necessary to check if TM is committed.
>>
>> Fixes: 5713ade69776 ("net/ixgbe: support committing TM hierarchy")
>>
>> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
>> ---
>> drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
>> index 194058f..e436dca 100644
>> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
>> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
>> @@ -2693,7 +2693,7 @@ static int eth_ixgbevf_pci_remove(struct rte_pci_device *pci_dev)
>> ixgbe_l2_tunnel_conf(dev);
>> ixgbe_filter_restore(dev);
>>
>> - if (!tm_conf->committed)
>> + if (tm_conf->root && !tm_conf->committed)
>> PMD_DRV_LOG(WARNING,
>> "please call hierarchy_commit() "
>> "before starting the port”);
>
> This patch may work on ixgbe, but I am using i40e and the message is still present. I tried to apply your logic above and that seemed to fix the i40e message.
>
> Looks like you need to change all of the drivers that use this logic.
>
> Here is the i40e change:
>
> i40e_dev_start()
> - if (!pf->tm_conf.committed)
> + if (pf->tm_conf.root && !pf->tm_conf.committed)
Just saw the new commit.
>
>> --
>> 1.9.3
>>
>
> Regards,
> Keith
Regards,
Keith
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-07-31 16:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-26 14:54 [dpdk-dev] [PATCH] net/ixgbe: fix hierarchy commit check Wenzhuo Lu
2017-07-26 15:17 ` Dumitrescu, Cristian
2017-07-31 16:53 ` Thomas Monjalon
2017-07-26 15:20 ` Wiles, Keith
2017-07-26 15:21 ` Wiles, Keith
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).