Re: [EXT] Re: [PATCH v2 1/1] devtools: update sources in build tags script

[Thomas Monjalon <thomas@monjalon.net>]

08/11/2023 15:42, Srikanth Yalavarthi:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 08/11/2023 10:28, Srikanth Yalavarthi:
> > > As part of deprecating kmods meson option, 'kernel/linux'
> > > directory is removed from the repository.
> > >
> > > This patch removes non-existing 'kernel/linux' directory from
> > > linux_sources of build tags script.
> > >
> > > Fixes: a52d472c5c94 ("build: deprecate kmods meson option")
> > 
> > If it is an old commit, you should probably add Cc: stable@dpdk.org You can
> > check with devtools/check-git-log.sh
> 
> The fixes commit (a52d472c5c94) was merged after 23.11-rc0. check-git-log.sh script wasn't suggested to submit this to stable@dpdk.log
> 
> My understanding is that Cc:stable@dpdk.org is need only if we need to backport the patch to older releases?

Your understanding is correct.
But here:
	git describe a52d472c5c94
	v23.07-183-ga52d472c5c

> > > Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> > 
> > You forgot the ack from Ferruh.
> > 
> > Srikanth, you are sending a lot of patches, which is good :) but we will ask you
> > to make an effort on getting all details.
> > You may read again the contributor's guide again.
> 
> Thanks. Apologies, Missed including Ack. Will take care of this.

No problem, it's always a pleasure to see newcomers becoming regular contributors.