From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D32A8A0C45; Tue, 5 Oct 2021 21:21:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5BA0C412C2; Tue, 5 Oct 2021 21:21:28 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 7A5824129A for ; Tue, 5 Oct 2021 21:21:27 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 2A4553200B25; Tue, 5 Oct 2021 15:21:26 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 05 Oct 2021 15:21:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= LGB0M3BEHvrj/vtC7Z74RIzYOCJRirFTNY1NS5k/ZJc=; b=PrZnbmAbElyQLTMd Rv6yfhnjF4AgrdCzxaRxCG58OGDdfoWQf5BAiOhgvn4tTaSd3ucPZO12ZPmAeAjO l97OX3ZeP3n0NYWl5hiXIj6dxxTGaKGO0o2RoColVBj+3gjV79cxki+3nUkmEGbV rKRv6KAoEINsh4mjW7RIQ5CD5MHofvuEFSXYZjeesFD+WQizsoK8MBCMMkTx8fUj 6jW2YuOdTqfbPCae4h4epfBsRAEP4iM6ok6FgR8A5/zWwOBtbabBpvbX9bwXo8vf D/M+sJBnBwgqOJg/J+byrYV4Y3Oc7lX2/ttNVVmHawjSTDVEWWQOq+c586qF8rC3 5y+msA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=LGB0M3BEHvrj/vtC7Z74RIzYOCJRirFTNY1NS5k/Z Jc=; b=fu+LPha8O2OHL0umH0ruNIxSyHKwil4MelVq9Wibl8FJOVWMrQBnKf8f2 y3h4yWsizAHtgHSM6E5AhGqaZTaVgUgY20etzycbzdi0TpFXDmXW3MQaiW93pkFk czi4YuR/dXl32oozmUrAWLbvwq/Hsel6wjA/KBr5uSbc/q1yyz/CD2mu7lrPHMkD rIp2TTZEFsUPsdGrfmJdbqqguw6T5HlKrZ+TR2fVJ22jB6xgX1+ctEd5en3WaV2n 3g1ZNqz91XUabjup1c6B03B5ekER7T07n62BjdFtCHM3MvNptMR6s7jhR7nEGXDZ HSdjbWgJKr/H/o0+sfkXtNngGyYGg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudelgedgudefhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 5 Oct 2021 15:21:23 -0400 (EDT) From: Thomas Monjalon To: "Min Hu (Connor)" Cc: dev@dpdk.org, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru Date: Tue, 05 Oct 2021 21:21:21 +0200 Message-ID: <2236789.hR5l6LFQDr@thomas> In-Reply-To: <20210922033630.41130-1-humin29@huawei.com> References: <20210922033630.41130-1-humin29@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: fix one MAC address occupies two index in mac addrs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 22/09/2021 05:36, Min Hu (Connor): > From: Huisong Li > > Use the testpmd to perform the following operations: > 1) mac_addr add 0 00:18:2D:00:00:90 > 2) mac_addr add 0 00:18:2D:00:00:91 > 3) mac_addr add 0 00:18:2D:00:00:92 > 4) mac_addr set 0 00:18:2D:00:00:91 > 5) show port 0 macs > Number of MAC address added: 4 > 00:18:2D:00:00:91 > 00:18:2D:00:00:90 > 00:18:2D:00:00:91 > 00:18:2D:00:00:92 Please describe with words. Reading similar MAC addresses is not a fun game. > This is due to the reason that if the address has been added as a > non-default MAC address by rte_eth_dev_mac_addr_add API, it doesn't remove > from dev->data->mac_addrs[] when set default MAC address with the same > address. > > Fixes: 854d8ad4ef68 ("ethdev: add default mac address modifier") > Cc: stable@dpdk.org > > Signed-off-by: Huisong Li > Signed-off-by: Min Hu (Connor)