From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50])
 by dpdk.org (Postfix) with ESMTP id 262FCC2DC
 for <dev@dpdk.org>; Sun, 17 May 2015 23:45:26 +0200 (CEST)
Received: by wgbhc8 with SMTP id hc8so134540261wgb.3
 for <dev@dpdk.org>; Sun, 17 May 2015 14:45:26 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=A94rzJRCYkQCnfP/GYmi+KGq+mu5JIMFNHEuEyPIk4Q=;
 b=JPqTfGX5ibGvi2ju/OmbAAtKTqIF8bBGsPJp5juDCbCXv+bBIVDTw7695ZjlkxsOYN
 1JHgwF1yO/x8rAwIor5MNOREGeDyth4SrAfvBEOcoAn7Cm8jcGEM1bC/+LCGDvc3n2iD
 RHtI3DQk7JVuWFBE9ZSkmYZfB3oYwJSgbNyjGIKdW//UQ6MNqZX9ghFeLAyKE28g2uew
 OwYJ41cC8YGTSI1VpJlYBfSiCarfze2iEcTxk5uBgLMSW4els4X2ng5hlDYeJUsa+qxs
 iyrocZKhKmLy9LFdC3RvgBcZFmFkWYV2CEhOrD2Y35hjGKhgAHoYfECEoerIXt/p0abE
 n9BQ==
X-Gm-Message-State: ALoCoQkFLJNS+WKREo9zII0yrnRZO4ujO9ZiYEt5+UZvcHiEhgP7hf7l99rPdX6JCysLwtez+tfm
X-Received: by 10.194.82.167 with SMTP id j7mr38801468wjy.123.1431899126022;
 Sun, 17 May 2015 14:45:26 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id js3sm13770546wjc.5.2015.05.17.14.45.24
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Sun, 17 May 2015 14:45:25 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Michal Jastrzebski <michalx.k.jastrzebski@intel.com>,
 Maciej Gajdzica <maciejx.t.gajdzica@intel.com>
Date: Sun, 17 May 2015 23:44:43 +0200
Message-ID: <22373976.yBms5me9Vj@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.7 (Linux/4.0.1-1-ARCH; KDE/4.14.7; x86_64; ; )
In-Reply-To: <1430395084-6172-2-git-send-email-michalx.k.jastrzebski@intel.com>
References: <1430395084-6172-1-git-send-email-michalx.k.jastrzebski@intel.com>
 <1430395084-6172-2-git-send-email-michalx.k.jastrzebski@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/3] port: added WRITER_APPROACH == 1
	implementation to ring port
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 17 May 2015 21:45:26 -0000

2015-04-30 13:58, Michal Jastrzebski:
> From: Maciej Gajdzica <maciejx.t.gajdzica@intel.com>
> 
> Added better optimized implementation of tx_bulk for ring writer port
> based on
> similar solution in ethdev_writer port. New implementation sends burst
> without
> copying data to internal buffer if it is possible.
> 
> Signed-off-by: Maciej Gajdzica <maciejx.t.gajdzica@intel.com>
[...]
> +#if RTE_PORT_RING_WRITER_APPROACH == 0

Nack
Maybe you missed the previous comment:
	http://dpdk.org/ml/archives/dev/2015-March/015999.html