DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH] doc/contributing: add line continuation note to meson guide
Date: Thu, 16 Sep 2021 10:44:55 +0200	[thread overview]
Message-ID: <2237488.fKQypoLauj@thomas> (raw)
In-Reply-To: <YUMA8JnIPX5wpD5c@bricha3-MOBL.ger.corp.intel.com>

16/09/2021 10:31, Bruce Richardson:
> On Thu, Sep 16, 2021 at 09:57:30AM +0200, Thomas Monjalon wrote:
> > 15/09/2021 11:50, Bruce Richardson:
> > > Add a note for the preference of using "()" rather than "\" for line
> > > continuations in meson.
> > > 
> > > Suggested-by: David Marchand <david.marchand@redhat.com>
> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > > ---
> > >  doc/guides/contributing/coding_style.rst | 10 ++++++++++
> > 
> > This is not the Meson guide.
> > 
> "coding style guide sub-section for meson" was too long to fit in the header.
>  :-)
> 
> > > --- a/doc/guides/contributing/coding_style.rst
> > > +++ b/doc/guides/contributing/coding_style.rst
> > > @@ -1024,6 +1024,16 @@ The following guidelines apply to the build system code in meson.build files in
> > >  * Line continuations should be doubly-indented to ensure visible difference from normal indentation.
> > >    Any line continuations beyond the first may be singly indented to avoid large amounts of indentation.
> > >  
> > > +* Where a line is split in the middle of a statement, e.g. a multiline `if` statement,
> > > +  brackets should be used in preference to escaping the line break.
> > 
> > Should we specify it is about Meson?
> > 
> 
> It's in a section entitled "Meson Coding Style"[1] so that should not be
> necessary.
> 
> 
> [1]https://doc.dpdk.org/guides-21.08/contributing/coding_style.html#meson-coding-style

OK I missed it. Sorry for the noise.



      reply	other threads:[~2021-09-16  8:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15  9:50 Bruce Richardson
2021-09-15 15:04 ` David Marchand
2021-09-23 11:48   ` Thomas Monjalon
2021-09-16  7:57 ` Thomas Monjalon
2021-09-16  8:31   ` Bruce Richardson
2021-09-16  8:44     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2237488.fKQypoLauj@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).