From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22572A0C41; Thu, 16 Sep 2021 10:45:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C6404069E; Thu, 16 Sep 2021 10:45:00 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 736EB4003F for ; Thu, 16 Sep 2021 10:44:59 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 0C1745C01AA; Thu, 16 Sep 2021 04:44:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 16 Sep 2021 04:44:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= /CrVQOKqZxETNMLHtzTdqqyomZzyqkF0QM5nBtwulPQ=; b=OR9UlehZvQCEyqTo mvz8aRewnIwkV8RVg89jfcKJ4KeRypdYjDLKi3IG1XRqmOW0Qyzjb+sjmxkFjUWw J3a7qjtqDkEgusZWF0lbBaPIPRN+F4dto5FgpibJgsgdP7lqJE0dnGUaoGmTMVsP l7ZsDvmWQG23pPWU//hFcybORXw4wT+47safQSILpeaZfr/KwxFA3bb6IvsA8UA1 n86llSZkapmI1R5GrJ3MkahrDD4/07RksixqqR4nd+WTCpH4rYNkVt/IXvzeEpLZ NhcRFJIdjMbu6UkW60mLCGdkcSYxfUkcgZqmsjy3zUqBq2wn1qx2B0sQBrRM3zml CE70lQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=/CrVQOKqZxETNMLHtzTdqqyomZzyqkF0QM5nBtwul PQ=; b=j5AckciAHIf1t5IekH5M8GVBm+9EwfqTMLjD5GbcrJa5EVxHgwjJYe1Qi NQP06aRcJQXFPYL4PeVAo+74QJSVefdyXNS9EKLuuF1fLqf0Qc7fJJK5a87jSrmJ fqNMbbSLGcnzREkBIheiE2kWBMbPMdk2jaYP0/hp9KeP6lpKKDcKbE48whY2OpZs yCY34aOPgXN4kQOcyDtqUS2MfCs0jCthqXavtx5KUJMzXrGHvpiaNHJT49xFJXUd ULEiKFRBBIuSATTrnkkmTzMEvXfm+Ljj0WWYp843v7zicDvtfqG4tkYIPyRFfof6 yxLNua8kXkneC0N6huEbynY1fyT0w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudehgedgtddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhn rdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 16 Sep 2021 04:44:57 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, david.marchand@redhat.com Date: Thu, 16 Sep 2021 10:44:55 +0200 Message-ID: <2237488.fKQypoLauj@thomas> In-Reply-To: References: <20210915095036.22346-1-bruce.richardson@intel.com> <2152077.EyU4qHBnM4@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc/contributing: add line continuation note to meson guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/09/2021 10:31, Bruce Richardson: > On Thu, Sep 16, 2021 at 09:57:30AM +0200, Thomas Monjalon wrote: > > 15/09/2021 11:50, Bruce Richardson: > > > Add a note for the preference of using "()" rather than "\" for line > > > continuations in meson. > > > > > > Suggested-by: David Marchand > > > Signed-off-by: Bruce Richardson > > > --- > > > doc/guides/contributing/coding_style.rst | 10 ++++++++++ > > > > This is not the Meson guide. > > > "coding style guide sub-section for meson" was too long to fit in the header. > :-) > > > > --- a/doc/guides/contributing/coding_style.rst > > > +++ b/doc/guides/contributing/coding_style.rst > > > @@ -1024,6 +1024,16 @@ The following guidelines apply to the build system code in meson.build files in > > > * Line continuations should be doubly-indented to ensure visible difference from normal indentation. > > > Any line continuations beyond the first may be singly indented to avoid large amounts of indentation. > > > > > > +* Where a line is split in the middle of a statement, e.g. a multiline `if` statement, > > > + brackets should be used in preference to escaping the line break. > > > > Should we specify it is about Meson? > > > > It's in a section entitled "Meson Coding Style"[1] so that should not be > necessary. > > > [1]https://doc.dpdk.org/guides-21.08/contributing/coding_style.html#meson-coding-style OK I missed it. Sorry for the noise.