From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Fan Zhang <roy.fan.zhang@intel.com>
Cc: dev@dpdk.org, declan.doherty@intel.com,
Pablo de Lara <pablo.de.lara.guarch@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4 0/4] app/test: rework crypto AES unit test
Date: Mon, 13 Jun 2016 22:26:26 +0200 [thread overview]
Message-ID: <2237985.4XU0RlZNqR@xps13> (raw)
In-Reply-To: <1465826893-20392-1-git-send-email-roy.fan.zhang@intel.com>
> Fan Zhang (4):
> app/test: categorize crypto AES test vectors into new file
> app/test: add unified crypto aes test
> app/test: utilize new unified crypto AES test function
> app/test: add crypto AES-CBC-128 HMAC-SHA224 and HMAC-SHA384 unit
> tests
My first comment on v1 was:
"
The first three patches have no real meaning separately.
As they move and rework some code, it is better to not split
with some patches which add code from nowhere and others which
remove old code.
Please squash.
"
Do you agree I squash the first 3 patches?
Any other reviewer for this big patchset?
next prev parent reply other threads:[~2016-06-13 20:26 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 9:09 [dpdk-dev] [PATCH 0/5] " Fan Zhang
2016-05-31 9:09 ` [dpdk-dev] [PATCH 1/5] app/test: categorize crypto AES test vectors into new file Fan Zhang
2016-05-31 9:09 ` [dpdk-dev] [PATCH 2/5] app/test: add unified crypto aes test Fan Zhang
2016-06-07 20:00 ` Thomas Monjalon
2016-05-31 9:09 ` [dpdk-dev] [PATCH 3/5] app/test: utilize new unified crypto AES test function Fan Zhang
2016-05-31 9:09 ` [dpdk-dev] [PATCH 4/5] app/test: add crypto AES-CBC-128 HMAC-SHA224 and HMAC-SHA384 unit tests Fan Zhang
2016-05-31 9:09 ` [dpdk-dev] [PATCH 5/5] examples/l2fwd-crypto: enable AES counter mode cipher algorithm Fan Zhang
2016-06-07 20:03 ` [dpdk-dev] [PATCH 0/5] app/test: rework crypto AES unit test Thomas Monjalon
2016-06-08 15:38 ` [dpdk-dev] [PATCH v2 0/4] " Fan Zhang
2016-06-08 15:38 ` [dpdk-dev] [PATCH v2 1/4] app/test: categorize crypto AES test vectors into new file Fan Zhang
2016-06-08 15:38 ` [dpdk-dev] [PATCH v2 2/4] app/test: add unified crypto aes test Fan Zhang
2016-06-08 15:38 ` [dpdk-dev] [PATCH v2 3/4] app/test: utilize new unified crypto AES test function Fan Zhang
2016-06-08 15:38 ` [dpdk-dev] [PATCH v2 4/4] app/test: add crypto AES-CBC-128 HMAC-SHA224 and HMAC-SHA384 unit tests Fan Zhang
2016-06-13 12:53 ` [dpdk-dev] [PATCH v3 0/4] app/test: rework crypto AES unit test Fan Zhang
2016-06-13 12:53 ` [dpdk-dev] [PATCH v3 1/4] app/test: categorize crypto AES test vectors into new file Fan Zhang
2016-06-13 12:53 ` [dpdk-dev] [PATCH v3 2/4] app/test: add unified crypto aes test Fan Zhang
2016-06-13 12:53 ` [dpdk-dev] [PATCH v3 3/4] app/test: utilize new unified crypto AES test function Fan Zhang
2016-06-13 12:53 ` [dpdk-dev] [PATCH v3 4/4] app/test: add crypto AES-CBC-128 HMAC-SHA224 and HMAC-SHA384 unit tests Fan Zhang
2016-06-13 14:08 ` [dpdk-dev] [PATCH v4 0/4] app/test: rework crypto AES unit test Fan Zhang
2016-06-13 14:08 ` [dpdk-dev] [PATCH v4 1/4] app/test: categorize crypto AES test vectors into new file Fan Zhang
2016-06-13 14:08 ` [dpdk-dev] [PATCH v4 2/4] app/test: add unified crypto aes test Fan Zhang
2016-06-13 14:08 ` [dpdk-dev] [PATCH v4 3/4] app/test: utilize new unified crypto AES test function Fan Zhang
2016-06-13 14:08 ` [dpdk-dev] [PATCH v4 4/4] app/test: add crypto AES-CBC-128 HMAC-SHA224 and HMAC-SHA384 unit tests Fan Zhang
2016-06-13 20:26 ` Thomas Monjalon [this message]
2016-06-14 9:57 ` [dpdk-dev] [PATCH v5 0/2] app/test: rework crypto AES unit test Fan Zhang
2016-06-14 9:57 ` [dpdk-dev] [PATCH v5 1/2] app/test: reworks the " Fan Zhang
2016-06-15 10:41 ` De Lara Guarch, Pablo
2016-06-21 2:57 ` Chen, Zhaoyan
2016-06-14 9:57 ` [dpdk-dev] [PATCH v5 2/2] app/test: add crypto AES-CBC-128 HMAC-SHA224 and HMAC-SHA384 unit tests Fan Zhang
2016-06-15 11:02 ` [dpdk-dev] [PATCH v6 0/2] rework crypto AES unit test Fan Zhang
2016-06-15 11:02 ` [dpdk-dev] [PATCH v6 1/2] app/test: rework the " Fan Zhang
2016-06-15 11:02 ` [dpdk-dev] [PATCH v6 2/2] app/test: add crypto AES-CBC-128 HMAC-SHA224 and HMAC-SHA384 unit tests Fan Zhang
2016-06-15 12:50 ` [dpdk-dev] [PATCH v6 0/2] rework crypto AES unit test De Lara Guarch, Pablo
2016-06-20 15:18 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2237985.4XU0RlZNqR@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).