From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id EA2662C09
 for <dev@dpdk.org>; Mon, 13 Jun 2016 22:26:28 +0200 (CEST)
Received: by mail-wm0-f54.google.com with SMTP id v199so93637583wmv.0
 for <dev@dpdk.org>; Mon, 13 Jun 2016 13:26:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=LiIqfSIOIzQIQIr/btpV2gFx00ubbGc/HIGnUTyjFzg=;
 b=HAm6f7udX1xXLFeAeq0GEpvlb+Md0XO78WRzTrWrX1sD3FC6EpG/KsqceUhtVZcAJt
 zW0LZpeyJinCVD5qm3ia41dwuBQQxYdCjpJkZoV56k00U5L9/5uRWVtoNKmCu0iUnXJ/
 AgJag0Vh5xVYnyKYP0I5yC/8H0HQTkRsOG4x02bggoSBtDgbhWJj5JsiOJbJ1v/jSSX9
 /qnXNuaxpbuhCm/rPP94PayZsAHBtxIEnyRpAIqr1HE7FxHeoJVI4/dnWuV1zk438cCX
 MCibDUuDoznBy+aSYqlHPpmx8kJ3pzN3Po5fpWslCIWknC5B7CiIg1TcYJffeboGT3+3
 rSOA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=LiIqfSIOIzQIQIr/btpV2gFx00ubbGc/HIGnUTyjFzg=;
 b=XegXjhQzLr57bqs5B2IM4aZ1FHpa3IZiC5he6//3M9qJRVtrVlxoDi3Abg5fzDFK6J
 ibGxGDUPo9spzO1UvlR1TZxPiO8EhfCxE7p8BP+DVy49RnBQk+g/Ih9x8dhkV3Hfn7fH
 tr3bvONfnM/zOnb3oQCrPugPK6BT/VYtqft9DzucSANZiwNaTpsWn3Paz5dnBDp3qyPl
 88Ekbul6s9eFLzcY70PFO+avzmDhFTJFYIy6bFDdtKMVLI5CvwkR3eC8P3JvqRo8kCxk
 HTLb6lj7QvWTlH6jyQ+gboYum1XnsboT907I767lVyf1C3xi0IqE5CdYI+En5AaErNS6
 i+sg==
X-Gm-Message-State: ALyK8tL97ex6JNKtACO+XCUZ0F4daHMcKT0q0WcRgkaqyIQdcTHJCljy6dH/m1ndsi39u49d
X-Received: by 10.28.170.21 with SMTP id t21mr3018785wme.0.1465849588755;
 Mon, 13 Jun 2016 13:26:28 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id l9sm29298795wjm.0.2016.06.13.13.26.27
 (version=TLSv1/SSLv3 cipher=OTHER);
 Mon, 13 Jun 2016 13:26:27 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Fan Zhang <roy.fan.zhang@intel.com>
Cc: dev@dpdk.org, declan.doherty@intel.com,
 Pablo de Lara <pablo.de.lara.guarch@intel.com>
Date: Mon, 13 Jun 2016 22:26:26 +0200
Message-ID: <2237985.4XU0RlZNqR@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1465826893-20392-1-git-send-email-roy.fan.zhang@intel.com>
References: <1465822420-8287-1-git-send-email-roy.fan.zhang@intel.com>
 <1465826893-20392-1-git-send-email-roy.fan.zhang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v4 0/4] app/test: rework crypto AES unit test
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jun 2016 20:26:29 -0000

> Fan Zhang (4):
>   app/test: categorize crypto AES test vectors into new file
>   app/test: add unified crypto aes test
>   app/test: utilize new unified crypto AES test function
>   app/test: add crypto AES-CBC-128 HMAC-SHA224 and HMAC-SHA384 unit
>     tests

My first comment on v1 was:
"
The first three patches have no real meaning separately.
As they move and rework some code, it is better to not split
with some patches which add code from nowhere and others which
remove old code.
Please squash.
"

Do you agree I squash the first 3 patches?

Any other reviewer for this big patchset?