From: Thomas Monjalon <thomas@monjalon.net>
To: "lihuisong (C)" <lihuisong@huawei.com>
Cc: dev@dpdk.org, stephen@networkplumber.org, ferruh.yigit@amd.com,
Ajit Khaparde <ajit.khaparde@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Praveen Shetty <praveen.shetty@intel.com>,
Andrew Boyer <andrew.boyer@amd.com>,
Dariusz Sosnowski <dsosnowski@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>,
Chaoyong He <chaoyong.he@corigine.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
fengchengwen@huawei.com
Subject: Re: [PATCH v1 2/2] ethdev: fix skip valid port in probing callback
Date: Tue, 14 Jan 2025 13:39:48 +0100 [thread overview]
Message-ID: <2239813.NgBsaNRSFp@thomas> (raw)
In-Reply-To: <93d2853a-ef15-5be6-5ef4-51ebd6b9b3ca@huawei.com>
14/01/2025 13:13, lihuisong (C):
> 在 2025/1/14 19:13, Thomas Monjalon 写道:
> > As explained above, we should not do allow much API from RTE_ETH_EVENT_NEW.
> > rte_eth_dev_socket_id() is reasonnable.
> > Functions rte_eth_dev_owner_*() are fine.
> > Others functions should be called only after probing.
>
> All right, will fix it in new patch set.
> And I'll also add these comments like above you said for RTE_ETH_EVENT_NEW.
Thank you
prev parent reply other threads:[~2025-01-14 12:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 2:55 [PATCH v1 0/2] " Huisong Li
2025-01-13 2:55 ` [PATCH v1 1/2] app/testpmd: check the validity of the port Huisong Li
2025-01-13 2:55 ` [PATCH v1 2/2] ethdev: fix skip valid port in probing callback Huisong Li
2025-01-13 8:16 ` Thomas Monjalon
2025-01-13 9:35 ` lihuisong (C)
2025-01-13 10:57 ` Thomas Monjalon
2025-01-13 11:23 ` lihuisong (C)
2025-01-13 12:05 ` lihuisong (C)
2025-01-13 12:30 ` Thomas Monjalon
2025-01-13 12:47 ` lihuisong (C)
2025-01-13 13:14 ` Thomas Monjalon
2025-01-14 1:50 ` lihuisong (C)
2025-01-14 11:13 ` Thomas Monjalon
2025-01-14 12:13 ` lihuisong (C)
2025-01-14 12:39 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2239813.NgBsaNRSFp@thomas \
--to=thomas@monjalon.net \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.boyer@amd.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bingz@nvidia.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=fengchengwen@huawei.com \
--cc=ferruh.yigit@amd.com \
--cc=lihuisong@huawei.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=praveen.shetty@intel.com \
--cc=somnath.kotur@broadcom.com \
--cc=stephen@networkplumber.org \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).