From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1DE26439A6; Tue, 23 Jan 2024 11:28:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9876F402B0; Tue, 23 Jan 2024 11:28:33 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id A5AA3400D7 for ; Tue, 23 Jan 2024 11:28:32 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 7AFCF5C0254; Tue, 23 Jan 2024 05:28:29 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 23 Jan 2024 05:28:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1706005709; x=1706092109; bh=IuUzVB2xBmvRa/jlBwdDUT6Dp7g4MvqJlihFygHEd44=; b= LKZSFYiqHABdGCnhDxXsgiL1sUg8f/fqLE3Unhor5JIETEsxWsQJEReHtMHf8DPO vbZgl0ikNzCJ3eGDCQu/vwJmDfHX2DxlT3dS4+UeQ5wC5dsnLQZGEc9jh9kq4ttP dEDbkVnywkOYWRXn1IfhqdX/oBi7ktcN1QYVdbzGF9aDGZPRbapiDgQTUhVf1VI/ 7k1AnOnX73WB+OMYquGSeprc7mkTv9/PkPXs3cKGcxBL7buTqwFdD8SF8cSk/4oc k9IJPTvqWGxIrLqZ0I0WOGBbiHiHynjUrqm1XjP68ksFtFW/GJhQTYAjtGu4FOCP yUhXCw/o74rv9YFWCJkX9g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1706005709; x= 1706092109; bh=IuUzVB2xBmvRa/jlBwdDUT6Dp7g4MvqJlihFygHEd44=; b=d yHIc4ewBuT2IK4JRgmEPKwsmdQNM9QFm9CYdU4TqOTyM3RruBjVPiXQOfAyGbXVg VW7IZdQbVHW2QXGrPeZVJ/xryJq9+y+w3/8WxV/+grtzowLjznsqZTz5VcaDnSEg nsSU+nDQPYWXIplvK8ttplGR8VsD8v95ah8Y2XvUbkkjvq7ho3JanM5DrTxU7uj9 gTf1ZcfmIJuE/F9TgCIzKLzNPPTGBUInUgcQEC7g37TORiTfM+MObPKtXMTF5UWN oHqtg3B57axorsjvrjnhFN9ZIfUnAaTBYg3PLLCU3vf3uKwC3GbUur1rrnfGR/Dz 0ZLodNe5zl0f2bmjA40wg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdekkedgudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 23 Jan 2024 05:28:28 -0500 (EST) From: Thomas Monjalon To: Dariusz Sosnowski , Stephen Hemminger Cc: dev@dpdk.org, Tyler Retzlaff , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Matan Azrad Subject: Re: [PATCH v5 07/10] net/mlx5: replace zero length array with flex array Date: Tue, 23 Jan 2024 11:28:26 +0100 Message-ID: <2240162.72vocr9iq0@thomas> In-Reply-To: <1758963.QkHrqEjB74@thomas> References: <20230113215205.125767-1-stephen@networkplumber.org> <20231129024221.57653-8-stephen@networkplumber.org> <1758963.QkHrqEjB74@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 23/01/2024 10:44, Thomas Monjalon: > 29/11/2023 03:39, Stephen Hemminger: > > --- a/drivers/net/mlx5/mlx5_tx.h > > +++ b/drivers/net/mlx5/mlx5_tx.h > > @@ -171,11 +171,12 @@ struct mlx5_txq_data { > > struct mlx5_txq_stats stats; /* TX queue counters. */ > > struct mlx5_txq_stats stats_reset; /* stats on last reset. */ > > struct mlx5_uar_data uar_data; > > - struct rte_mbuf *elts[0]; > > + struct rte_mbuf *elts[]; > > /* Storage for queued packets, must be the last field. */ > > } __rte_cache_aligned; > > > > /* TX queue control descriptor. */ > > +__extension__ > > struct mlx5_txq_ctrl { > > struct mlx5_txq_data is included at the end of struct mlx5_txq_ctrl > I don't understand why we need to declare an extension here. If I remove __extension__: error: invalid use of structure with flexible array member [-Werror=pedantic] Is it a problem only in pedantic mode?