DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>,
	Anoob Joseph <anoobj@marvell.com>,
	Akhil Goyal <akhil.goyal@nxp.com>,
	Declan Doherty <declan.doherty@intel.com>,
	Aviad Yehezkel <aviadye@mellanox.com>,
	Boris Pismenny <borisp@mellanox.com>,
	Radu Nicolau <radu.nicolau@intel.com>,
	Anoob Joseph <anoob.joseph@caviumnetworks.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2 01/13] security: fix verification of parameters
Date: Thu, 09 Apr 2020 12:54:10 +0200
Message-ID: <22404743.ouqheUzb2q@thomas> (raw)
In-Reply-To: <20200409101445.GA613@bricha3-MOBL.ger.corp.intel.com>

09/04/2020 12:14, Bruce Richardson:
> On Wed, Apr 08, 2020 at 07:51:35PM +0200, Thomas Monjalon wrote:
> > 08/04/2020 17:49, Lukasz Wojciechowski:
> > > Hi guys,
> > > 
> > > I don't know what is the current status of "legacy" build using 
> > > gnumakes, so I added the new DEBUG flag to config just as it was done in 
> > > other libs like eventdev.
> > > Many guides still point config files as the one that should be changed 
> > > in order to enable some features, so I thought I should add it there.
> > > 
> > > If I understand well the official build system now is the one based on 
> > > using meson and ninja, however it hasn't got anything similar to the 
> > > gnamakefiles system, e.g.
> > > in the meson.build file for libraries all the libraries have build 
> > > variable set to true and there are few ifs that check it, but as it's 
> > > set to true all libraries build always.
> > > And each library considered there defines RTE_LIBRTE_[LIBRARY_NAME]. 
> > > It's kind of weird.
> > > 
> > >     foreach l:libraries
> > >     *    build = true**
> > >     *    reason = '<unknown reason>' # set if build == false to explain why
> > >          ...
> > >     *    if not build*
> > >              dpdk_libs_disabled += name
> > >              set_variable(name.underscorify() + '_disable_reason', reason)
> > >          else
> > >              enabled_libs += name
> > >     *dpdk_conf.set('RTE_LIBRTE_' + name.to_upper(), 1)*
> > >          ...
> > > 
> > > Have you think about reusing config files in meson configuration and 
> > > have a single point of configuration? Of course all meson flags can 
> > > overwrite the default config.
> > 
> > This is on purpose.
> > We are removing most of compile-time options with meson.
> > 
> > I think we can use a global option for debug-specific code.
> > Bruce, what do you recommend?
> > 
> Meson has a built-in global debug setting which could be used. However,
> that may be too course-grained. If that is the case there are a couple of
> options:
> 
> 1 Each library can have it's own debug flag defined, which is set on
>   the commandline in CFLAGS. Can be done right now - just reuse any of the
>   debug variables in the existing make config files (stripping off the
>   CONFIG_), e.g. CFLAGS=-DRTE_MALLOC_DEBUG
> 2 Since that is perhaps not the most usable - though easiest to implement -
>   we can look to add a general debug option (or couple of options) in
>   meson, e.g. debug_libs=, debug_drivers=, where each option takes a list of
>   libs or drivers to pass the debug flags to. This will require a little
>   work in the meson build infrastructure, but is not that hard. The harder
>   part is standardizing the debug flags across all components.
> 
> The advantage of #1 is that it works today and just needs some
> documentation for each lib/driver what it's debug flags are. The advantage
> of #2 is more usability, but it requires a lot more work to standardize
> IMHO.

In this case, we need a general option as the one already provided by meson.
It means: "I am not in production, I want to see anything behaving wrong
in the datapath."
"Anything" means we don't need a per-library switch.
And for the other needs (out of fast path), we have a new function:
	rte_log_can_log(mylogtype, RTE_LOG_DEBUG)



  reply	other threads:[~2020-04-09 10:54 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200312151708eucas1p2a80bb2ac0556c7d7efb3aedd83923e52@eucas1p2.samsung.com>
2020-03-12 15:16 ` [dpdk-dev] [PATCH 00/13] Fixes and unit tests for librte_security Lukasz Wojciechowski
     [not found]   ` <CGME20200312151708eucas1p2acee543b5f9d236b8e43cd4d1fbed489@eucas1p2.samsung.com>
2020-03-12 15:16     ` [dpdk-dev] [PATCH 01/13] librte_security: fix verification of parameters Lukasz Wojciechowski
2020-03-17 12:59       ` Anoob Joseph
2020-04-03 18:36         ` Lukasz Wojciechowski
2020-04-05 12:54           ` [dpdk-dev] [EXT] " Anoob Joseph
2020-04-06 18:49             ` Lukasz Wojciechowski
2020-04-07  6:20               ` Anoob Joseph
2020-04-08  3:25                 ` Lukasz Wojciechowski
     [not found]   ` <CGME20200312151708eucas1p12db7c8e402be03dd255d53114217dabd@eucas1p1.samsung.com>
2020-03-12 15:16     ` [dpdk-dev] [PATCH 02/13] librte_security: fix return types in documentation Lukasz Wojciechowski
2020-03-17 16:34       ` Anoob Joseph
     [not found]   ` <CGME20200312151708eucas1p2536ef1df74b35ead436db85f8a5628b4@eucas1p2.samsung.com>
2020-03-12 15:16     ` [dpdk-dev] [PATCH 03/13] librte_security: fix session counter Lukasz Wojciechowski
2020-03-17 17:08       ` Anoob Joseph
     [not found]   ` <CGME20200312151708eucas1p18d3cde72ccadf22d43b8907ab9de6d97@eucas1p1.samsung.com>
2020-03-12 15:16     ` [dpdk-dev] [PATCH 04/13] app/test: fix macro definition Lukasz Wojciechowski
     [not found]   ` <CGME20200312151709eucas1p2df38aed23b7445d3db7d4d3ea8fe3222@eucas1p2.samsung.com>
2020-03-12 15:16     ` [dpdk-dev] [PATCH 05/13] app/test: introduce librte_security tests Lukasz Wojciechowski
2020-04-01 17:09       ` Akhil Goyal
2020-04-01 17:51         ` Thomas Monjalon
2020-04-02 19:49           ` Lukasz Wojciechowski
2020-04-02 20:51             ` Thomas Monjalon
2020-04-03 19:24         ` Lukasz Wojciechowski
     [not found]   ` <CGME20200312151709eucas1p1a01f789059de888cb2d719526434e4f9@eucas1p1.samsung.com>
2020-03-12 15:16     ` [dpdk-dev] [PATCH 06/13] app/test: add rte_security_session_update tests Lukasz Wojciechowski
     [not found]   ` <CGME20200312151709eucas1p139311cecb925f566cbbf1444d14c31b1@eucas1p1.samsung.com>
2020-03-12 15:16     ` [dpdk-dev] [PATCH 07/13] app/test: add rte_security_session_get_size tests Lukasz Wojciechowski
     [not found]   ` <CGME20200312151709eucas1p15263f75e2ad73aa9b8d2fb2d4cf51439@eucas1p1.samsung.com>
2020-03-12 15:16     ` [dpdk-dev] [PATCH 08/13] app/test: add rte_security_session_stats_get tests Lukasz Wojciechowski
     [not found]   ` <CGME20200312151710eucas1p22f051449e6e7edeadefe65b66ffaed32@eucas1p2.samsung.com>
2020-03-12 15:16     ` [dpdk-dev] [PATCH 09/13] app/test: add rte_security_session_destroy tests Lukasz Wojciechowski
     [not found]   ` <CGME20200312151710eucas1p10124737620ec6414aa593e7fa67ee56b@eucas1p1.samsung.com>
2020-03-12 15:16     ` [dpdk-dev] [PATCH 10/13] app/test: add rte_security_set_pkt_metadata tests Lukasz Wojciechowski
     [not found]   ` <CGME20200312151710eucas1p1c3590b55d00bea25b26539a560199b96@eucas1p1.samsung.com>
2020-03-12 15:16     ` [dpdk-dev] [PATCH 11/13] app/test: add rte_security_get_userdata tests Lukasz Wojciechowski
     [not found]   ` <CGME20200312151710eucas1p21882b138d4fd79753f993c30c997e615@eucas1p2.samsung.com>
2020-03-12 15:16     ` [dpdk-dev] [PATCH 12/13] app/test: add rte_security_capabilities_get tests Lukasz Wojciechowski
     [not found]   ` <CGME20200312151710eucas1p1fd5b1484c9ee807327d2d34511a47a12@eucas1p1.samsung.com>
2020-03-12 15:16     ` [dpdk-dev] [PATCH 13/13] app/test: add rte_security_capability_get tests Lukasz Wojciechowski
     [not found]   ` <CGME20200408031435eucas1p23b452d748e39e46c626f695b7f55096a@eucas1p2.samsung.com>
2020-04-08  3:13     ` [dpdk-dev] [PATCH v2 00/13] Fixes and unit tests for librte_security Lukasz Wojciechowski
     [not found]       ` <CGME20200408031447eucas1p1376332353faa0d217e7be8c32271405f@eucas1p1.samsung.com>
2020-04-08  3:13         ` [dpdk-dev] [PATCH v2 01/13] security: fix verification of parameters Lukasz Wojciechowski
2020-04-08 12:54           ` Thomas Monjalon
2020-04-08 13:02             ` Anoob Joseph
2020-04-08 13:26               ` Thomas Monjalon
2020-04-08 14:44                 ` [dpdk-dev] [EXT] " Anoob Joseph
2020-04-08 15:49                   ` Lukasz Wojciechowski
2020-04-08 17:51                     ` Thomas Monjalon
2020-04-09 10:14                       ` Bruce Richardson
2020-04-09 10:54                         ` Thomas Monjalon [this message]
2020-04-09 11:13                           ` Bruce Richardson
2020-04-09 14:07                             ` Lukasz Wojciechowski
2020-04-09 14:21                               ` Lukasz Wojciechowski
2020-04-09 15:22                                 ` Thomas Monjalon
2020-04-09 16:10                                   ` Lukasz Wojciechowski
2020-04-10  8:45                                     ` Bruce Richardson
     [not found]       ` <CGME20200408031448eucas1p2b36997fc73f5b5e2aadb6e4bb965063b@eucas1p2.samsung.com>
2020-04-08  3:13         ` [dpdk-dev] [PATCH v2 02/13] security: fix return types in documentation Lukasz Wojciechowski
     [not found]       ` <CGME20200408031448eucas1p2d6df7ff419bb093606a2f9115297f45a@eucas1p2.samsung.com>
2020-04-08  3:13         ` [dpdk-dev] [PATCH v2 03/13] security: fix session counter Lukasz Wojciechowski
     [not found]       ` <CGME20200408031449eucas1p1ca89719463cbaf29e9f7c81beaec88c2@eucas1p1.samsung.com>
2020-04-08  3:13         ` [dpdk-dev] [PATCH v2 04/13] app/test: fix macro definition Lukasz Wojciechowski
2020-04-08 12:53           ` Thomas Monjalon
2020-04-08 16:15             ` Lukasz Wojciechowski
2020-04-08 17:47               ` Thomas Monjalon
2020-04-09 14:10                 ` Lukasz Wojciechowski
     [not found]       ` <CGME20200408031450eucas1p1a0b6ca84cbac2f7542212e185de1ddf5@eucas1p1.samsung.com>
2020-04-08  3:13         ` [dpdk-dev] [PATCH v2 05/13] app/test: introduce librte security tests Lukasz Wojciechowski
     [not found]       ` <CGME20200408031451eucas1p2769ae9d814ef1ccd286407767054e117@eucas1p2.samsung.com>
2020-04-08  3:13         ` [dpdk-dev] [PATCH v2 06/13] app/test: add rte security session update tests Lukasz Wojciechowski
     [not found]       ` <CGME20200408031451eucas1p2313bee1d227e5966fb37c5326aa72529@eucas1p2.samsung.com>
2020-04-08  3:13         ` [dpdk-dev] [PATCH v2 07/13] app/test: add rte security session get size tests Lukasz Wojciechowski
     [not found]       ` <CGME20200408031452eucas1p2f75a75363e148c54f38b01b9a9a0ea47@eucas1p2.samsung.com>
2020-04-08  3:13         ` [dpdk-dev] [PATCH v2 08/13] app/test: add rte security session stats get tests Lukasz Wojciechowski
     [not found]       ` <CGME20200408031452eucas1p1b4de173fadca62824b472b8a3dd69e32@eucas1p1.samsung.com>
2020-04-08  3:13         ` [dpdk-dev] [PATCH v2 09/13] app/test: add rte security session destroy tests Lukasz Wojciechowski
     [not found]       ` <CGME20200408031453eucas1p15bf7f54b1a5b1ae7810a72c71bd6271c@eucas1p1.samsung.com>
2020-04-08  3:13         ` [dpdk-dev] [PATCH v2 10/13] app/test: add rte security set pkt metadata tests Lukasz Wojciechowski
     [not found]       ` <CGME20200408031453eucas1p1b26ad6b1f924b817e83fc2d2d61a0b0b@eucas1p1.samsung.com>
2020-04-08  3:13         ` [dpdk-dev] [PATCH v2 11/13] app/test: add rte security get userdata tests Lukasz Wojciechowski
     [not found]       ` <CGME20200408031454eucas1p112c6eded420bdcfdb09fad83bf485afb@eucas1p1.samsung.com>
2020-04-08  3:13         ` [dpdk-dev] [PATCH v2 12/13] app/test: add rte security capabilities get tests Lukasz Wojciechowski
     [not found]       ` <CGME20200408031454eucas1p2e09e0ab0a1ffa5c657bcf35d89c40a55@eucas1p2.samsung.com>
2020-04-08  3:13         ` [dpdk-dev] [PATCH v2 13/13] app/test: add rte security capability " Lukasz Wojciechowski
     [not found]       ` <CGME20200409172528eucas1p1186911653001cab0e69f10fc42790023@eucas1p1.samsung.com>
2020-04-09 17:24         ` [dpdk-dev] [PATCH v3 00/13] Fixes and unit tests for librte_security Lukasz Wojciechowski
     [not found]           ` <CGME20200409172529eucas1p1f02aaf66052f45ac75ba9e9f63ef1c3a@eucas1p1.samsung.com>
2020-04-09 17:24             ` [dpdk-dev] [PATCH v3 01/13] security: fix verification of parameters Lukasz Wojciechowski
2020-04-13 15:42               ` Anoob Joseph
     [not found]           ` <CGME20200409172530eucas1p27297a83a9d7508e3f8a8f88850cbe37c@eucas1p2.samsung.com>
2020-04-09 17:24             ` [dpdk-dev] [PATCH v3 02/13] security: fix return types in documentation Lukasz Wojciechowski
2020-04-13 15:43               ` Anoob Joseph
     [not found]           ` <CGME20200409172531eucas1p1c3ec21532e5e232ff2d68d56f096e71c@eucas1p1.samsung.com>
2020-04-09 17:24             ` [dpdk-dev] [PATCH v3 03/13] security: fix session counter Lukasz Wojciechowski
2020-04-13 15:48               ` Anoob Joseph
     [not found]           ` <CGME20200409172532eucas1p285bc6767be1d62a0098d177a7757169f@eucas1p2.samsung.com>
2020-04-09 17:24             ` [dpdk-dev] [PATCH v3 04/13] app/test: remove macro definition Lukasz Wojciechowski
     [not found]           ` <CGME20200409172533eucas1p1f4363aa89cfbda87e5d20da1006e21c0@eucas1p1.samsung.com>
2020-04-09 17:24             ` [dpdk-dev] [PATCH v3 05/13] app/test: introduce librte security tests Lukasz Wojciechowski
     [not found]           ` <CGME20200409172533eucas1p252ed0cac1689b067a83589a0665c9033@eucas1p2.samsung.com>
2020-04-09 17:24             ` [dpdk-dev] [PATCH v3 06/13] app/test: add rte security session update tests Lukasz Wojciechowski
     [not found]           ` <CGME20200409172534eucas1p2ee383bc5d8efd40ea8b883b78126ed9f@eucas1p2.samsung.com>
2020-04-09 17:24             ` [dpdk-dev] [PATCH v3 07/13] app/test: add rte security session get size tests Lukasz Wojciechowski
     [not found]           ` <CGME20200409172534eucas1p2852ae56687fd5bae343437b07198c070@eucas1p2.samsung.com>
2020-04-09 17:24             ` [dpdk-dev] [PATCH v3 08/13] app/test: add rte security session stats get tests Lukasz Wojciechowski
     [not found]           ` <CGME20200409172535eucas1p152b3d17bd9d2194f9f2669116130331d@eucas1p1.samsung.com>
2020-04-09 17:24             ` [dpdk-dev] [PATCH v3 09/13] app/test: add rte security session destroy tests Lukasz Wojciechowski
     [not found]           ` <CGME20200409172535eucas1p2c215489de77c708fc0bec6b9e2e3dd6d@eucas1p2.samsung.com>
2020-04-09 17:24             ` [dpdk-dev] [PATCH v3 10/13] app/test: add rte security set pkt metadata tests Lukasz Wojciechowski
     [not found]           ` <CGME20200409172536eucas1p282854dae8a3b6cceafdea5e2f4fa0896@eucas1p2.samsung.com>
2020-04-09 17:25             ` [dpdk-dev] [PATCH v3 11/13] app/test: add rte security get userdata tests Lukasz Wojciechowski
     [not found]           ` <CGME20200409172536eucas1p1396c04fb7a9fb80db2a5670f8f3453bb@eucas1p1.samsung.com>
2020-04-09 17:25             ` [dpdk-dev] [PATCH v3 12/13] app/test: add rte security capabilities get tests Lukasz Wojciechowski
     [not found]           ` <CGME20200409172538eucas1p1dcd99eeedf6fca44c2e2e53e94b08d91@eucas1p1.samsung.com>
2020-04-09 17:25             ` [dpdk-dev] [PATCH v3 13/13] app/test: add rte security capability " Lukasz Wojciechowski
2020-04-17 19:46           ` [dpdk-dev] [PATCH v3 00/13] Fixes and unit tests for librte_security Akhil Goyal
2020-04-17 20:14             ` Lukasz Wojciechowski
2020-04-17 20:21               ` Akhil Goyal
2020-04-17 20:39                 ` Lukasz Wojciechowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22404743.ouqheUzb2q@thomas \
    --to=thomas@monjalon.net \
    --cc=akhil.goyal@nxp.com \
    --cc=anoob.joseph@caviumnetworks.com \
    --cc=anoobj@marvell.com \
    --cc=aviadye@mellanox.com \
    --cc=borisp@mellanox.com \
    --cc=bruce.richardson@intel.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=l.wojciechow@partner.samsung.com \
    --cc=radu.nicolau@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git