DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Laatz, Kevin" <kevin.laatz@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	"Walsh, Conor" <conor.walsh@intel.com>
Subject: Re: [PATCH] dma/idxd: fix return value for pci device commands
Date: Wed, 08 Jun 2022 10:54:59 +0200	[thread overview]
Message-ID: <2240626.ElGaqSPkdT@thomas> (raw)
In-Reply-To: <CO1PR11MB5201E39F5B766EA5DE106DD8FFA59@CO1PR11MB5201.namprd11.prod.outlook.com>

07/06/2022 12:56, Walsh, Conor:
> 
> > Subject: [PATCH] dma/idxd: fix return value for pci device commands
> > 
> > When sending a command to an idxd device via pci bar, the response from
> > HW is checked to ensure it was successful. The response was incorrectly
> > being negated before being returned by the function, meaning error codes
> > cannot be checked against the HW specification.
> > 
> > This patch fixes the return values of the function by removing the
> > negation.
> > 
> > Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> 
> Acked-by: Conor Walsh <conor.walsh@intel.com>

Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe")
Fixes: 452c1916b0db ("dma/idxd: fix truncated error code in status check")
Cc: stable@dpdk.org

Please don't forget above lines in future.

Applied, thanks.



  reply	other threads:[~2022-06-08  8:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-08 14:16 Kevin Laatz
2022-06-07 10:56 ` Walsh, Conor
2022-06-08  8:54   ` Thomas Monjalon [this message]
2022-06-08  8:57     ` Kevin Laatz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2240626.ElGaqSPkdT@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=conor.walsh@intel.com \
    --cc=dev@dpdk.org \
    --cc=kevin.laatz@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).