From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE26DA0548; Wed, 8 Jun 2022 10:55:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9FEA140689; Wed, 8 Jun 2022 10:55:05 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id D5DA34021D for ; Wed, 8 Jun 2022 10:55:03 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 781E73200A94; Wed, 8 Jun 2022 04:55:02 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 08 Jun 2022 04:55:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1654678501; x= 1654764901; bh=JkH6rlqnz+MCHsXobryyEyF8stxxJBzBFizHNUsIkfk=; b=F KUIiRqwE4Mf/JsrF2Es3gL0jWVLMVvJCclr93pbx5+JFIzv4B5pIEfsHimQ/CALf 4PXFnrlv2MK1UJcdN7z1XNKXGd9+PwCRPRkL+jnSLOmgs6yXoPS+jRYu9ICRaGpH HiyKvCLuxc/oJ+eQXn4RBBL8xYp1nh/SEb0PtPWhxZ0yzTv4xNk6BpMSn0S0G3YR DPFZ3QMBMJiQNi7ns+WyJylZZQg4JWOzx2wMuorH9pcy8HvyPaUCZ2PZDSlt6SFo QfrkdvKvkBUN2ROIoWQp9/68+X1IFblvhffn5qSWRqtRdXm/C+P69Jk9b0xP9GAq Hf9ZsfdYjHeVtjwOi0LEw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1654678501; x= 1654764901; bh=JkH6rlqnz+MCHsXobryyEyF8stxxJBzBFizHNUsIkfk=; b=l KznKQ/XYMnwBudDKL6IOUn+OkQws0wlr1SWUNzb3nj8RyHff0QWHdAabJOVOaNNc 5N4/Vl7U1D4skpipv/QrnqR/46cSiNi8usycxUP/pGRqiBX4r3JNLwuIvMn0m2Fd zAgq9ElzFuTXJ9qUG8V43QXx/1+QWh7IS6BqDn6iOHS6lUbZCe7TDtbYH25nK55y pqnmC1aIFqITAFhcKx8Hcx3t5YpnjSPTp0xAFMlIaJ6WV7K4rIWag4v9Oni+AMfp dApJYEUUsWBAW/GMfW7d8Pl8M8BeE0O30yTsCyLvXnTx6L7kIqp4c+bKhmKtujK+ KD+KPdp1eDYOvK50mIvTA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedruddtjedgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 8 Jun 2022 04:55:01 -0400 (EDT) From: Thomas Monjalon To: "Laatz, Kevin" Cc: "dev@dpdk.org" , "Richardson, Bruce" , "Walsh, Conor" Subject: Re: [PATCH] dma/idxd: fix return value for pci device commands Date: Wed, 08 Jun 2022 10:54:59 +0200 Message-ID: <2240626.ElGaqSPkdT@thomas> In-Reply-To: References: <20220408141655.1320288-1-kevin.laatz@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 07/06/2022 12:56, Walsh, Conor: > > > Subject: [PATCH] dma/idxd: fix return value for pci device commands > > > > When sending a command to an idxd device via pci bar, the response from > > HW is checked to ensure it was successful. The response was incorrectly > > being negated before being returned by the function, meaning error codes > > cannot be checked against the HW specification. > > > > This patch fixes the return values of the function by removing the > > negation. > > > > Signed-off-by: Kevin Laatz > > Acked-by: Conor Walsh Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe") Fixes: 452c1916b0db ("dma/idxd: fix truncated error code in status check") Cc: stable@dpdk.org Please don't forget above lines in future. Applied, thanks.