* [PATCH] argparse: enable code to be compiled with MSVC compiler
@ 2024-11-12 22:48 Andre Muezerie
2024-11-13 0:30 ` fengchengwen
2024-11-15 14:54 ` David Marchand
0 siblings, 2 replies; 4+ messages in thread
From: Andre Muezerie @ 2024-11-12 22:48 UTC (permalink / raw)
To: Chengwen Feng; +Cc: dev, Andre Muezerie
The issues that were preventing argparser from getting compiled with
MSVC were fixed, so now it should not be excluded from the
compilation anymore.
Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
lib/argparse/meson.build | 6 ------
1 file changed, 6 deletions(-)
diff --git a/lib/argparse/meson.build b/lib/argparse/meson.build
index 8ab4c408ee..b6a08ca049 100644
--- a/lib/argparse/meson.build
+++ b/lib/argparse/meson.build
@@ -1,12 +1,6 @@
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2024 HiSilicon Limited.
-if is_ms_compiler
- build = false
- reason = 'not supported building with Visual Studio Toolset'
- subdir_done()
-endif
-
sources = files('rte_argparse.c')
headers = files('rte_argparse.h')
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] argparse: enable code to be compiled with MSVC compiler
2024-11-12 22:48 [PATCH] argparse: enable code to be compiled with MSVC compiler Andre Muezerie
@ 2024-11-13 0:30 ` fengchengwen
2024-11-19 10:17 ` Thomas Monjalon
2024-11-15 14:54 ` David Marchand
1 sibling, 1 reply; 4+ messages in thread
From: fengchengwen @ 2024-11-13 0:30 UTC (permalink / raw)
To: Andre Muezerie; +Cc: dev
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
On 2024/11/13 6:48, Andre Muezerie wrote:
> The issues that were preventing argparser from getting compiled with
> MSVC were fixed, so now it should not be excluded from the
> compilation anymore.
>
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> ---
> lib/argparse/meson.build | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/lib/argparse/meson.build b/lib/argparse/meson.build
> index 8ab4c408ee..b6a08ca049 100644
> --- a/lib/argparse/meson.build
> +++ b/lib/argparse/meson.build
> @@ -1,12 +1,6 @@
> # SPDX-License-Identifier: BSD-3-Clause
> # Copyright(c) 2024 HiSilicon Limited.
>
> -if is_ms_compiler
> - build = false
> - reason = 'not supported building with Visual Studio Toolset'
> - subdir_done()
> -endif
> -
> sources = files('rte_argparse.c')
> headers = files('rte_argparse.h')
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] argparse: enable code to be compiled with MSVC compiler
2024-11-13 0:30 ` fengchengwen
@ 2024-11-19 10:17 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2024-11-19 10:17 UTC (permalink / raw)
To: Andre Muezerie; +Cc: dev, fengchengwen
13/11/2024 01:30, fengchengwen:
> On 2024/11/13 6:48, Andre Muezerie wrote:
> > The issues that were preventing argparser from getting compiled with
> > MSVC were fixed, so now it should not be excluded from the
> > compilation anymore.
> >
> > Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
>
> Acked-by: Chengwen Feng <fengchengwen@huawei.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] argparse: enable code to be compiled with MSVC compiler
2024-11-12 22:48 [PATCH] argparse: enable code to be compiled with MSVC compiler Andre Muezerie
2024-11-13 0:30 ` fengchengwen
@ 2024-11-15 14:54 ` David Marchand
1 sibling, 0 replies; 4+ messages in thread
From: David Marchand @ 2024-11-15 14:54 UTC (permalink / raw)
To: Andre Muezerie; +Cc: Chengwen Feng, dev, Tyler Retzlaff, Thomas Monjalon
On Tue, Nov 12, 2024 at 11:48 PM Andre Muezerie
<andremue@linux.microsoft.com> wrote:
>
> The issues that were preventing argparser from getting compiled with
> MSVC were fixed, so now it should not be excluded from the
> compilation anymore.
Just to be sure, it relates to fixes of bz 1409, right?
It's cool no new regression was introduced in the mean time.
Enabling libraries the sooner is better for getting a larger MSVC
support, I see no problem in taking this patch for rc3.
>
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-11-19 10:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-12 22:48 [PATCH] argparse: enable code to be compiled with MSVC compiler Andre Muezerie
2024-11-13 0:30 ` fengchengwen
2024-11-19 10:17 ` Thomas Monjalon
2024-11-15 14:54 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).