From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 054EE4330F; Sun, 12 Nov 2023 15:23:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8BC424021F; Sun, 12 Nov 2023 15:23:04 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id 283C34021E for ; Sun, 12 Nov 2023 15:23:03 +0100 (CET) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 4FBC332005BC; Sun, 12 Nov 2023 09:23:01 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 12 Nov 2023 09:23:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1699798980; x=1699885380; bh=bxBy8OFNOkDvil6bY/TkEVxadrRXxbN5QVr L2FnGosM=; b=rB+dxYRpflVUjuXN521hg1tey0l+tin0mqvOdRJ1tWpuz2Vb49a t911K8rYrSjlSj7xx5ISXgY/fRcMflam86lIXGPe7cQuw26BeTmf6USyfapXQoXl A1zi6TMAbE7z09xRxLP4pXyWWV38n26jDsGUKsI4KJjTawURextkvM2bO/R70nto R3upOzB/glzajKSZU+RV/nnr+aRDZcu0puzpfqTUcLgZRlQAPXo7HUdyKpOi2Mr3 5F6SQ+jIrTgdWce1vJtqcZvmsRVTxX+sv8EzDlZsnGdKdRC3UYMPNcxf0uudrX9M D3x0nUllm+Q12b934hne79jkppfh4nO21ZQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1699798980; x=1699885380; bh=bxBy8OFNOkDvil6bY/TkEVxadrRXxbN5QVr L2FnGosM=; b=mvJET6T/SeXP3sKP77CWXjoAJqqKAy9FoFGiikiHSqyTMaUVo7E 7Gd587Im8p+bvaRwFK9w7igmX5d58li8/apFKFPRS4g5h+1zzS7HD14yry5SNKUQ BS42inM9ZQN/oiLowTMmNwP5dBAJq4JJMsK2j561I7sw7IoyCyOlMhu08IrnSkod /6XMq72UbfBkXIgDkkmJEAorF4UlxDtqWotA636TvI1zfvcChuCCDs/EIrMduHzv nFlvUAjqtxMUYzfeaCbiIVUc98fZp449bq2m/1wB3m62x6gUQlhSv/NIjKtkf3y0 tzMGe7qTPo3GsKL4FDIz0q/aAVbqFeR/UEQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedruddvkedgieehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtudenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeefhfejleeuvdevtddutdeutdevhfeijeethfffueejhfetuddu vedtkedtieekffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 12 Nov 2023 09:22:58 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, Morten =?ISO-8859-1?Q?Br=F8rup?= , Reshma Pattan , Jerin Jacob , Kiran Kumar K , Nithin Dabilpuram , Zhirun Yan , Quentin Armitage , Stephen Hemminger Subject: Re: [PATCH v5 3/5] pcapng: modify timestamp calculation Date: Sun, 12 Nov 2023 15:22:57 +0100 Message-ID: <2244244.iZASKD2KPV@thomas> In-Reply-To: <20231109194557.111350-4-stephen@networkplumber.org> References: <20230921042349.104150-1-stephen@networkplumber.org> <20231109194557.111350-1-stephen@networkplumber.org> <20231109194557.111350-4-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 09/11/2023 20:45, Stephen Hemminger: > The computation of timestamp is best done in the part of > pcapng library that is in secondary process. > The secondary process is already doing a bunch of system > calls which makes it not performance sensitive. > This does change the rte_pcapng_copy() > and rte_pcapng_write_stats() experimental API's. >=20 > Simplify the computation of nanoseconds from TSC to a two > step process which avoids numeric overflow issues. The previous > code was not thread safe as well. >=20 > Fixes: c882eb544842 ("pcapng: fix timestamp wrapping in output files") > Signed-off-by: Stephen Hemminger > Acked-by: Morten Br=F8rup It does not compile: app/test/test_pcapng.c:148:22: error: too many arguments to function 'rte_pcapng_copy' Please make sure it compiles after each patch. Thank you