From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id B28F05F1C for <dev@dpdk.org>; Sat, 31 Mar 2018 02:05:39 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 400D620F24; Fri, 30 Mar 2018 20:05:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 30 Mar 2018 20:05:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=EJYrnRs1z34UuWkZnooFB2WxLm IHz4uBSf4sLiDBlYo=; b=HmPQAYNX8/wXrfDVs8xpMdzhgbKB88YVlcP2aVIaHF o2sFVllzA50ly9GC9WPlsGNEDpG5jBviyBueVyu1MW6WdPGI51nYHSc9gf8Lp9K1 PEL8eeMS8dPGpJ77T4GMM/6Bazt1tYXqeJDsY3gom67YxrY+e2c5yDxJNl86DlsK M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=EJYrnR s1z34UuWkZnooFB2WxLmIHz4uBSf4sLiDBlYo=; b=mERMnD/qOWroye7sVogmZL 6RkiI5qxOCZvRSRDHXIt11NA7pcWVC/sSmLFbArnz2VHw+zEqZxO5SjsUbzgSMCD s3QglJU5CI3atp/ns8JKl4CorB4zmHycmMfqIX1uQBkejuRR5qhIEPoL+gNLvibp BkPcAjvr9mxgeIYVC3tYBcr5L/KuLttjRWZqvAOkM9yJ16hZsqkqw2zYScxiRFPi YrLwjFds80VhdwMXfIgm+s87pyoqMCIvBDaAWmQVmYPX/6daSxvTaG1104zF8/X0 AkAAiHh6S/Jyj6vAm/ffZRb0f1dIF6WpTGj5WI0fMA8wTCWxtDVPApX9oeiy6nFg == X-ME-Sender: <xms:09C-WsMo0lrR_bey2YVXeP9impT3J-0Pht7jm5TxS1GOUgO1gg5n7g> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 132E9E43C8; Fri, 30 Mar 2018 20:05:37 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Ferruh Yigit <ferruh.yigit@intel.com>, Remy Horton <remy.horton@intel.com> Cc: dev@dpdk.org, John McNamara <john.mcnamara@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>, Qi Zhang <qi.z.zhang@intel.com>, Beilei Xing <beilei.xing@intel.com>, Shreyansh Jain <shreyansh.jain@nxp.com> Date: Sat, 31 Mar 2018 02:05:22 +0200 Message-ID: <2244353.QZW83d2S2R@xps> In-Reply-To: <44b33e0e-9a1b-86ce-24ab-d123b9a1068e@intel.com> References: <20180321142749.27520-1-remy.horton@intel.com> <8f7021b0-ea88-d2a9-c2df-080a6aabc78e@intel.com> <44b33e0e-9a1b-86ce-24ab-d123b9a1068e@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 0/4] ethdev: add per-PMD tuning of RxTx parmeters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Sat, 31 Mar 2018 00:05:40 -0000 30/03/2018 12:34, Ferruh Yigit: > On 3/27/2018 7:43 PM, Ferruh Yigit wrote: > > On 3/21/2018 2:27 PM, Remy Horton wrote: > >> The optimal values of several transmission & reception related parameters, > >> such as burst sizes, descriptor ring sizes, and number of queues, varies > >> between different network interface devices. This patchset allows individual > >> PMDs to specify their preferred parameter values, and if so indicated by an > >> application, for them to be used automatically by the ethdev layer. > >> > >> rte_eth_dev_configure() has been changed so that specifying zero for both > >> nb_rx_q AND nb_tx_q causes it to use driver preferred values, and if these > >> are not available, falls back to EAL defaults. Setting one (but not both) > >> to zero does not cause the use of defaults, as having one of them zeroed is > >> a valid setup. > >> > >> This RFC/V1 includes per-PMD values for e1000 and i40e but it is expected > >> that subsequent patchsets will cover other PMDs. A deprecation notice > >> covering the API/ABI change is in place. > >> > >> > >> Changes in v2: > >> * Rebased to > >> * Removed fallback values from rte_eth_dev_info_get() > >> * Added fallback values to rte_rte_[rt]x_queue_setup() > >> * Added fallback values to rte_eth_dev_configure() > >> * Corrected comment > >> * Removed deprecation notice > >> * Split RX and Tx into seperate structures > >> * Changed parameter names > >> > >> > >> Remy Horton (4): > >> ethdev: add support for PMD-tuned Tx/Rx parameters > >> net/e1000: add TxRx tuning parameters > >> net/i40e: add TxRx tuning parameters > >> testpmd: make use of per-PMD TxRx parameters > > > > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com> > > Series applied to dpdk-next-net/master, thanks. I prefer not pulling this series in master and give a chance to have a more complete v3 for testpmd and examples.