* [dpdk-dev] [PATCH] net/enic: heed VLAN strip flag in device configure function
@ 2016-07-19 22:43 John Daley
2016-07-20 2:05 ` David Harton (dharton)
0 siblings, 1 reply; 3+ messages in thread
From: John Daley @ 2016-07-19 22:43 UTC (permalink / raw)
To: dev; +Cc: bruce.richardson, John Daley
The configure function enicpmd_dev_configure() was not paying attention
to the rxmode VLAN strip bit. Set the VLAN strip mode according to the bit.
Fixes: fefed3d1e62c ("enic: new driver")
Signed-off-by: John Daley <johndale@cisco.com>
---
Although not critical, it is low risk and would be nice to have in 16_07.
drivers/net/enic/enic_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c
index 59082d2..47b07c9 100644
--- a/drivers/net/enic/enic_ethdev.c
+++ b/drivers/net/enic/enic_ethdev.c
@@ -356,6 +356,7 @@ static int enicpmd_dev_configure(struct rte_eth_dev *eth_dev)
eth_dev->data->dev_conf.rxmode.split_hdr_size);
}
+ enicpmd_vlan_offload_set(eth_dev, ETH_VLAN_STRIP_MASK);
enic->hw_ip_checksum = eth_dev->data->dev_conf.rxmode.hw_ip_checksum;
return 0;
}
--
2.7.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/enic: heed VLAN strip flag in device configure function
2016-07-19 22:43 [dpdk-dev] [PATCH] net/enic: heed VLAN strip flag in device configure function John Daley
@ 2016-07-20 2:05 ` David Harton (dharton)
2016-07-21 22:52 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: David Harton (dharton) @ 2016-07-20 2:05 UTC (permalink / raw)
To: John Daley (johndale), dev; +Cc: bruce.richardson
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of John Daley (johndale)
> Sent: Tuesday, July 19, 2016 6:44 PM
> To: dev@dpdk.org
> Cc: bruce.richardson@intel.com; John Daley (johndale) <johndale@cisco.com>
> Subject: [dpdk-dev] [PATCH] net/enic: heed VLAN strip flag in device
> configure function
>
> The configure function enicpmd_dev_configure() was not paying attention to
> the rxmode VLAN strip bit. Set the VLAN strip mode according to the bit.
>
> Fixes: fefed3d1e62c ("enic: new driver")
>
> Signed-off-by: John Daley <johndale@cisco.com>
> ---
>
> Although not critical, it is low risk and would be nice to have in 16_07.
>
> drivers/net/enic/enic_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/enic/enic_ethdev.c
> b/drivers/net/enic/enic_ethdev.c index 59082d2..47b07c9 100644
> --- a/drivers/net/enic/enic_ethdev.c
> +++ b/drivers/net/enic/enic_ethdev.c
> @@ -356,6 +356,7 @@ static int enicpmd_dev_configure(struct rte_eth_dev
> *eth_dev)
> eth_dev->data->dev_conf.rxmode.split_hdr_size);
> }
>
> + enicpmd_vlan_offload_set(eth_dev, ETH_VLAN_STRIP_MASK);
> enic->hw_ip_checksum = eth_dev->data-
> >dev_conf.rxmode.hw_ip_checksum;
> return 0;
> }
> --
> 2.7.0
Reviewed-by: David Harton <dharton@cisco.com>
Tested-by: David Harton <dharton@cisco.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/enic: heed VLAN strip flag in device configure function
2016-07-20 2:05 ` David Harton (dharton)
@ 2016-07-21 22:52 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2016-07-21 22:52 UTC (permalink / raw)
To: John Daley (johndale); +Cc: dev, David Harton (dharton), bruce.richardson
> > The configure function enicpmd_dev_configure() was not paying attention to
> > the rxmode VLAN strip bit. Set the VLAN strip mode according to the bit.
> >
> > Fixes: fefed3d1e62c ("enic: new driver")
> >
> > Signed-off-by: John Daley <johndale@cisco.com>
>
> Reviewed-by: David Harton <dharton@cisco.com>
> Tested-by: David Harton <dharton@cisco.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-21 22:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-19 22:43 [dpdk-dev] [PATCH] net/enic: heed VLAN strip flag in device configure function John Daley
2016-07-20 2:05 ` David Harton (dharton)
2016-07-21 22:52 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).