From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 183E8AAC0 for ; Wed, 18 Apr 2018 15:50:26 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9057E21CCA; Wed, 18 Apr 2018 09:50:25 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 18 Apr 2018 09:50:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=LUXZlvYFuwWpHEpYIQH6u+oJKn wOVNTcLCdXjDb1hQk=; b=duICi0eKhHZtAOIx2MnBYfnuMc08FBfunkayh/d2S4 Wk6A8bBsxomnSMkx6q7xuEPu9+iuDEjggLSe0/vippfS2EeOiX54IYEp1Fk3hnWS NymMaDZIO6Y0OoUOeWqegSOomzYrK3tH/EwiqwLoaZOAaH4DMiig1Imc6zNSW/TK E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=LUXZlv YFuwWpHEpYIQH6u+oJKnwOVNTcLCdXjDb1hQk=; b=ieqd92KEi/X+Jd1g43Q9Pa HjD3hv29gvBaz6RXrMfUlBCq3KXYQMBfwAVt6S/P5pYVpTVVXOnG0BWCZ75af1Kw 5hYXU55ebyELzvzHbhTxAdkmbwJOat4ecvssUBUenDGCP85NSVCdyEtFav7yXPhC 7Ntyu6uEUjNLLk4AKXYbCtNd6gKNVshRmlWfd9ycfaq2ry0hnJpHA3tj1WRIHVeU mMVyqShlzEAhFspFfHVAuOllH8cV3+zLyUW5GHYP9LqZErfB04zw2QUgtl1iE/YL 4LBLkqsJ+UeyTGr4BhKS867tTk6LTgwuGYK1XDcMyE1NsogYg4h2s4HYJent2cRA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D30F9E50A5; Wed, 18 Apr 2018 09:50:24 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: Scott Branden , Stephen Hemminger , dev@dpdk.org Date: Wed, 18 Apr 2018 15:50:23 +0200 Message-ID: <2245312.U4dFV0f5su@xps> In-Reply-To: <20180418085605.GA111744@bricha3-MOBL.ger.corp.intel.com> References: <20180417214919.8246-1-stephen@networkplumber.org> <4245883.kl7A9e8lPX@xps> <20180418085605.GA111744@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [RFC] checkpatch: don't complain about SPDX tag format X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Apr 2018 13:50:26 -0000 18/04/2018 10:56, Bruce Richardson: > On Wed, Apr 18, 2018 at 12:19:07AM +0200, Thomas Monjalon wrote: > > 18/04/2018 00:11, Scott Branden: > > > On 18-04-17 03:06 PM, Thomas Monjalon wrote: > > > > 17/04/2018 23:49, Stephen Hemminger: > > > >> IMHO would have been better to use the kernel SPDX style and > > > >> keep the check but that appears to be a minority opinion. > > > > > > > > I think it is better to work on checkpatch itself. > > > > When defining our SPDX style, Linux one was not definitive. > > > > Do you think we can ask the Linux community to support our SPDX style? > > > > > > > I think it better to simply follow the Linux community defacto style > > > rather than go your own way. > > > > But our way is better! :) > > And it has been decided in the Technical Board. > > > > As a general issue, I think we could do with having our own checkpatch-like > script for performing addition DPDK-specific code-checks *after* Linux > checkpatch ones. That is, reuse Linux check patch checks as much as > possible, but have other checks too. +1 to call more scripts in checkpatches.sh. We need to find the right language to do code checks. Coccinelle looks to be a good candidate for some checks. > For example, check for use of strcpy or strncpy (or snprintf with "%s") and > suggest replacing with strlcpy. If we did have our own extension script, we > could put our own SPDX format check there too. > > Thoughts, or any volunteers to look into this? I am not volunteer to start the work but I would be glad to contribute later. Any motivated volunteer?