From: Thomas Monjalon <thomas@monjalon.net>
To: Reshma Pattan <reshma.pattan@intel.com>
Cc: dev@dpdk.org, david.hunt@intel.com,
jananeex.m.parthasarathy@intel.com, bruce.richardson@intel.com,
ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH] app/test: fix shared library build failure
Date: Wed, 25 Apr 2018 00:51:14 +0200 [thread overview]
Message-ID: <2245500.3bhCTCqs5i@xps> (raw)
In-Reply-To: <1524607821-19809-1-git-send-email-reshma.pattan@intel.com>
title changed to "test/power: fix build with shared library"
25/04/2018 00:10, Reshma Pattan:
> Using private api `guest_channel_host_connect()`
> will cause shared library build failure.
Adding the log:
test_power_kvm_vm.c:(.text+0x2cb):
undefined reference to `guest_channel_host_connect'
> So revert the changes done.
>
> Fixes: d550a8cc31 ("app/test: enhance power manager unit tests")
Exact line has a longer id:
Fixes: d550a8cc31f3 ("app/test: enhance power manager unit tests")
> Signed-off-by: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
Adding more credits:
Reported-by: Bruce Richardson <bruce.richardson@intel.com>
Suggested-by: David Hunt <david.hunt@intel.com>
Applied, thanks
next prev parent reply other threads:[~2018-04-24 22:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 22:10 Reshma Pattan
2018-04-24 22:51 ` Thomas Monjalon [this message]
2018-04-25 11:59 ` Parthasarathy, JananeeX M
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2245500.3bhCTCqs5i@xps \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jananeex.m.parthasarathy@intel.com \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).