From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 8255E4D27
for <dev@dpdk.org>; Wed, 25 Apr 2018 00:51:16 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 13B7121687;
Tue, 24 Apr 2018 18:51:16 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Tue, 24 Apr 2018 18:51:16 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc; s=mesmtp; bh=SYe1MeznGK2ypxq11AE55U9G89
wSFx6dj87TntMP80E=; b=Zfme6q6isiWzpspQ30niajHLZlEnESmeRfYIUBSiAG
44hQQgMJrMCXqPZo3BZn8beGKBCd1GJMC2pSAgZ4ISz+sYfPkzwOESmFrwy4PqUo
Snx9nRBJ1siVq8CV9j7YftUvSw2F5Fv2SRCj7LGOT6Ww2G2WyQdhLHViYtOOkcUe
k=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=SYe1Me
znGK2ypxq11AE55U9G89wSFx6dj87TntMP80E=; b=hjdLen+QtWuk+rEe+FIpZG
xLTxO+FjQpmTejW07vjs6QegSI2xKTSgraKHULQqO8TmtotgcVNqxzuamKyj86n5
EFvLdu8hqxT409tceiWfijTv5GZledzQhjYvf8VOcMqTg/PSIs22lPSEZ4tEOWyt
E2UZ8osrT+a4C9VkN8zxa8pTJxy1T9x7n/3rrFmQIcyuamTGYoZY4M3MFX0JFzCx
BaLcc9nRI2ajIhkUTJu1pLaSvDccwTCEDbBtI8sE+pgIB6D78NH+h460yyxNoyzL
aov3K2G3DnKcZHV/bf05klpe8jkMvlHmJ4pDpvDBXn9Zmg1uQ27JslomLdT+lPUA
==
X-ME-Sender: <xms:5LTfWvMfd-sfBJhXDvksOGW1K4Ef9HSkZpUiGzTcDyGWqraTVxjzSg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 39B5AE4B94;
Tue, 24 Apr 2018 18:51:15 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Reshma Pattan <reshma.pattan@intel.com>
Cc: dev@dpdk.org, david.hunt@intel.com, jananeex.m.parthasarathy@intel.com,
bruce.richardson@intel.com, ferruh.yigit@intel.com
Date: Wed, 25 Apr 2018 00:51:14 +0200
Message-ID: <2245500.3bhCTCqs5i@xps>
In-Reply-To: <1524607821-19809-1-git-send-email-reshma.pattan@intel.com>
References: <1524607821-19809-1-git-send-email-reshma.pattan@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] app/test: fix shared library build failure
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Apr 2018 22:51:16 -0000
title changed to "test/power: fix build with shared library"
25/04/2018 00:10, Reshma Pattan:
> Using private api `guest_channel_host_connect()`
> will cause shared library build failure.
Adding the log:
test_power_kvm_vm.c:(.text+0x2cb):
undefined reference to `guest_channel_host_connect'
> So revert the changes done.
>
> Fixes: d550a8cc31 ("app/test: enhance power manager unit tests")
Exact line has a longer id:
Fixes: d550a8cc31f3 ("app/test: enhance power manager unit tests")
> Signed-off-by: Jananee Parthasarathy <jananeex.m.parthasarathy@intel.com>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
Adding more credits:
Reported-by: Bruce Richardson <bruce.richardson@intel.com>
Suggested-by: David Hunt <david.hunt@intel.com>
Applied, thanks