From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 336B1A04B5; Tue, 27 Oct 2020 16:56:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CB78C72DF; Tue, 27 Oct 2020 16:56:05 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id A7C8972DE for ; Tue, 27 Oct 2020 16:56:03 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 2BFD05C0183; Tue, 27 Oct 2020 11:56:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 27 Oct 2020 11:56:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= yCH5nmBt3l/1uHymncX2wVG5gr9InbVSxyV/RXX9YAE=; b=Mx597s/cVj967EVD 3xuC+79pXt69EqStqe/29IswrkAZINqTIJYgC/wk1IjV3AZ6rLCfXuMUeW8vWxHl u3NgYQkvZrhze9lT1HLzQPwlun+4BtBBN2r5HQK3IjDe4mekwOS0t0EGRP6ehQ+k eO4ddWQccyvmBj6IVudFF+m/1aX9kwCtaVhys0H9YVLNyTZ9DaH0P0f4jDIdXJOR nu8MUyA5s5oZxu6jDcAQ5oG9gHnhPxb91ESqAPfWAbW+fpRC0Gi3IkdX73sxOAix i7KuxXXFGcA7AKke5fyhIPaIPX4itjYZaZPeojCxHt0F7SnNbGG8kiISMKAs6XT2 kRBh5Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=yCH5nmBt3l/1uHymncX2wVG5gr9InbVSxyV/RXX9Y AE=; b=Gjp6eDcQI9HIAyb7VzKciFtR+G0tgHAhiKZBT0MeaiRy9ZK376aRaoZTR Rn+V4gWexGTl5POISlLa2z0EvCrfkvYWgHBNzxFUmFYinsRhh01t+aw2mPwWDAQj e3peHCCz2aEPGNCTSxv5dAvAe4BF6y7rmyjHAx/LZuRR52emXRqJQ4a5O8t8fWme /2bG9cTTnIdT3HJqHfnd/3/xOYk/odyFv0bQSg2h+Uk2nZNtgLW+emVEkm/9RLnW L2D3wT64/omgEmrPdrq9A3LJof53sytfHiHlXfshk49jp01Kd9GuYPzUSkORsu9l /aUwyO9UFyTEdG4R+TJnnnXKqQ/Eg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrkeelgdekudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgepudenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E0DFA328005A; Tue, 27 Oct 2020 11:56:00 -0400 (EDT) From: Thomas Monjalon To: Ed Czeck Cc: dev@dpdk.org, Ferruh Yigit , david.marchand@redhat.com, "Richardson, Bruce" , Olivier MATZ , andrew.rybchenko@oktetlabs.ru, akhil.goyal@nxp.com, Shepard Siegel , John Miller Date: Tue, 27 Oct 2020 16:55:58 +0100 Message-ID: <2247372.p4sHLASWvk@thomas> In-Reply-To: References: <20201026052105.1561859-1-thomas@monjalon.net> <20201026222013.2147904-8-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 07/15] net/ark: ignore user data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/10/2020 16:32, Ed Czeck: > HI Thomas, > Atomic Rules will be submitting a patch to connect user_data into the > mbuf stuct using > the dynfield interface restoring lost functionality from this patch. I don't understand what you are looking for. The user data has no meaning, and is removed. Please explain your use case and what you need. Does it mean you ack this patch? > You can expect a patch in the next few days. Are you targeting this > patch series for the 20.11 release? Yes 20.11-rc2 (this week) is the target. > On Mon, Oct 26, 2020 at 6:20 PM Thomas Monjalon wrote: > > > > The second field of metadata is reserved for user data > > which is a deprecated mbuf field. > > The usage of mbuf udata64 is removed > > and the corresponding ark metadata field is annotated as ignored. > > > > Signed-off-by: Thomas Monjalon > > --- > > drivers/net/ark/ark_ddm.h | 2 +- > > drivers/net/ark/ark_ethdev_rx.c | 1 - > > drivers/net/ark/ark_ethdev_tx.c | 1 - > > drivers/net/ark/ark_udm.h | 2 +- > > 4 files changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/ark/ark_ddm.h b/drivers/net/ark/ark_ddm.h > > index 5456b4b5cc..99eded8524 100644 > > --- a/drivers/net/ark/ark_ddm.h > > +++ b/drivers/net/ark/ark_ddm.h > > @@ -19,7 +19,7 @@ > > /* struct defining Tx meta data -- fixed in FPGA -- 16 bytes */ > > struct ark_tx_meta { > > uint64_t physaddr; > > - uint32_t user1; > > + uint32_t user1; /* ignored */ > > uint16_t data_len; /* of this MBUF */ > > #define ARK_DDM_EOP 0x01 > > #define ARK_DDM_SOP 0x02 > > diff --git a/drivers/net/ark/ark_ethdev_rx.c b/drivers/net/ark/ark_ethdev_rx.c > > index 2f8d05099c..5ead67e6b8 100644 > > --- a/drivers/net/ark/ark_ethdev_rx.c > > +++ b/drivers/net/ark/ark_ethdev_rx.c > > @@ -272,7 +272,6 @@ eth_ark_recv_pkts(void *rx_queue, > > mbuf->pkt_len = meta->pkt_len; > > mbuf->data_len = meta->pkt_len; > > mbuf->timestamp = meta->timestamp; > > - mbuf->udata64 = meta->user_data; > > > > if (ARK_DEBUG_CORE) { /* debug sanity checks */ > > if ((meta->pkt_len > (1024 * 16)) || > > diff --git a/drivers/net/ark/ark_ethdev_tx.c b/drivers/net/ark/ark_ethdev_tx.c > > index a0e35af880..8a0a9381f7 100644 > > --- a/drivers/net/ark/ark_ethdev_tx.c > > +++ b/drivers/net/ark/ark_ethdev_tx.c > > @@ -70,7 +70,6 @@ eth_ark_tx_meta_from_mbuf(struct ark_tx_meta *meta, > > uint8_t flags) > > { > > meta->physaddr = rte_mbuf_data_iova(mbuf); > > - meta->user1 = (uint32_t)mbuf->udata64; > > meta->data_len = rte_pktmbuf_data_len(mbuf); > > meta->flags = flags; > > } > > diff --git a/drivers/net/ark/ark_udm.h b/drivers/net/ark/ark_udm.h > > index 5846c825b8..ba436ee25b 100644 > > --- a/drivers/net/ark/ark_udm.h > > +++ b/drivers/net/ark/ark_udm.h > > @@ -18,7 +18,7 @@ > > /* Meta data structure apssed from FPGA, must match layout in FPGA */ > > struct ark_rx_meta { > > uint64_t timestamp; > > - uint64_t user_data; > > + uint64_t user_data; /* ignored */ > > uint8_t port; > > uint8_t dst_queue; > > uint16_t pkt_len; > > -- > > 2.28.0