From: "Yigit, Ferruh" <ferruh.yigit@linux.intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>
Cc: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add profiling for Rx/Tx burst routines
Date: Mon, 30 Sep 2019 13:32:28 +0100 [thread overview]
Message-ID: <22474f7f-ccac-05e8-ef5c-33d06b1df294@linux.intel.com> (raw)
In-Reply-To: <20190701081514.GA380@bricha3-MOBL.ger.corp.intel.com>
On 7/1/2019 9:15 AM, Bruce Richardson wrote:
> On Mon, Jul 01, 2019 at 04:57:30AM +0000, Slava Ovsiienko wrote:
>> I think we should compromise: keep existing RTE_TEST_PMD_RECORD_CORE_CYCLES
>> and extend with runtime switch under this build-time option:
>>
>> #ifdef RTE_TEST_PMD_RECORD_CORE_CYCLES
>> if (record_tx)
>> .. gather tx related stats...
>> if (record_rx)
>> .. gather rx related stats...
>> #endif
>>
>> This is very specific feature, it is needed while debugging and testing datapath
>> routines, and It seems this feature with appropriate overhead should not be always enabled.
>> existing build-time configuration options looks OK as for me.
+1, if we will enable this I am for having compile time config options.
Only a concern about the implementation, 'RTE_TEST_PMD_RECORD_CORE_CYCLES' and
'RTE_TEST_PMD_RECORD_CORE_RX_CYCLES' are both using same variable, like
'start_rx_tsc', is there an assumption that both won't be enabled at same time?
I think better to able to enable CORE_CYCLES, RX_CYCLES and TX_CYCLES separately
/ independently.
Another think to consider, for long term - not for this patch, to move introduce
RX/TX ifdefs to ethdev Rx/Tx functions so that all applications can use them,
not just testpmd.
>>
>> Bruce, if proposed runtime extension is acceptable - I will update the patch.
>>
> Ok for me.>
> Thanks,
> /Bruce
>
next prev parent reply other threads:[~2019-09-30 12:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 12:48 Viacheslav Ovsiienko
2019-06-26 12:57 ` Bruce Richardson
2019-06-26 13:19 ` Slava Ovsiienko
2019-06-26 13:21 ` Bruce Richardson
2019-06-27 4:48 ` Slava Ovsiienko
2019-06-28 13:45 ` Iremonger, Bernard
2019-06-28 14:20 ` Bruce Richardson
2019-07-01 4:57 ` Slava Ovsiienko
2019-07-01 8:15 ` Bruce Richardson
2019-09-30 12:32 ` Yigit, Ferruh [this message]
2020-03-19 13:50 ` [dpdk-dev] [PATCH v2 0/3] app/testpmd: qualify Rx/Tx profiling data on burst size Viacheslav Ovsiienko
2020-03-19 13:50 ` [dpdk-dev] [PATCH v2 1/3] app/testpmd: add profiling flags set command Viacheslav Ovsiienko
2020-04-02 11:15 ` Thomas Monjalon
2020-04-09 11:56 ` Ferruh Yigit
2020-04-13 7:56 ` Slava Ovsiienko
2020-04-13 12:23 ` Thomas Monjalon
2020-04-14 9:07 ` Ferruh Yigit
2020-03-19 13:50 ` [dpdk-dev] [PATCH v2 2/3] app/testpmd: gather Rx and Tx routines profiling Viacheslav Ovsiienko
2020-04-02 11:20 ` Thomas Monjalon
2020-04-02 11:23 ` Slava Ovsiienko
2020-03-19 13:50 ` [dpdk-dev] [PATCH v2 3/3] app/testpmd: qualify profiling statistics on burst size Viacheslav Ovsiienko
2020-03-20 6:13 ` Jerin Jacob
2020-04-09 11:46 ` Ferruh Yigit
2020-04-09 12:49 ` Jerin Jacob
2020-03-20 16:03 ` Andrzej Ostruszka
2020-04-02 11:21 ` Thomas Monjalon
2020-04-09 12:03 ` Ferruh Yigit
2020-04-09 12:09 ` Thomas Monjalon
2020-04-02 11:13 ` [dpdk-dev] [PATCH v2 0/3] app/testpmd: qualify Rx/Tx profiling data " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22474f7f-ccac-05e8-ef5c-33d06b1df294@linux.intel.com \
--to=ferruh.yigit@linux.intel.com \
--cc=bernard.iremonger@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).