From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1286EA04DC; Tue, 20 Oct 2020 16:33:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E52AAAD12; Tue, 20 Oct 2020 16:33:35 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 02829AD12 for ; Tue, 20 Oct 2020 16:33:32 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 9D04B580381; Tue, 20 Oct 2020 10:33:32 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 20 Oct 2020 10:33:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= AAB2s3zqCpaKg3FpSzlzHDQDzHLRpIilJ7bBBcq8Qhw=; b=oRtpMchcDtvDhrwj Mj+znLHOce+55G+Zg42WbScfDQcyCDtcApxUiOGoblzYKd4X7bmlIKa/suLvmHRi Hb1WX4c4mDfLEBJjLJJVRwzFUTxtALT3sKoSYTVw33ulPlLs84e0E3i7wV92fNCF CrtbMNl4VdpsR2q9lSr/3gPGHhlj5+914mfRfydIfp0Uz1mjcdPzKoxJ3L1F5Eb3 zLbm5vTYjsqLGvWSiEh/vK7RIPjbAkhrMveNRu6SpVz9pcoinDYqFuJDoYb2wnkM ZjHyN9gJqHFAXYnMUnISl1Gpt8TYu/pWGpXmZuNli95Tkawj5cIKLAGBXnQe3qP9 pkSbkQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=AAB2s3zqCpaKg3FpSzlzHDQDzHLRpIilJ7bBBcq8Q hw=; b=fQ0tICqvvSCEGvbSO87oEuf3DHv14i+rNDzXVrPO/VDrZsaQROkW5dtZ0 lMIH1S3J8o50BbpbgIDo/pFlduUU770Wsm6aGnhmOJbcF1G6j7SDNC7DP9O9T59j tFwmqa4AIX8RtGrDxhErYXf0aex/YTJ2YZ1wvUaK/XSp4J8NyOkA1T4btpOEaebj Js2/1JJAZVw+h0kJ/Nlw8Ks0WfSzJZkDsZqnjYl7EmlPP37vbTr5bRako87p9GxG op6Sd7uT8z1DA7+wy5cdJSpyPNC/myU7Nq9qK1fK89Ne69DLOUMfoMdYwjZO8lka fsn+ftAhuRSfIyKh2iDJv9J9ZQ3VQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrjeefgdejiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 348B0328005A; Tue, 20 Oct 2020 10:33:30 -0400 (EDT) From: Thomas Monjalon To: David Hunt Cc: Honnappa Nagarahalli , Ruifeng Wang , "dev@dpdk.org" , Liang Ma , Jan Viktorin , David Christensen , Bruce Richardson , Konstantin Ananyev , "jerinjacobk@gmail.com" , "timothy.mcdaniel@intel.com" , "gage.eads@intel.com" , "chris.macnamara@intel.com" , Anatoly Burakov , "david.marchand@redhat.com" , nd Date: Tue, 20 Oct 2020 16:33:29 +0200 Message-ID: <2249719.vHQDUtK1Li@thomas> In-Reply-To: <7d18f72e-9078-1eb9-ab6f-d88992ac082c@intel.com> References: <73102e35-00d3-fb5e-0169-ba7015880ed8@intel.com> <7d18f72e-9078-1eb9-ab6f-d88992ac082c@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 02/10] eal: add power management intrinsics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/10/2020 16:17, David Hunt: > On 20/10/2020 3:01 PM, David Hunt wrote: > > On 20/10/2020 8:35 AM, Thomas Monjalon wrote: > >> 20/10/2020 04:49, Ruifeng Wang: > >>> From: Thomas Monjalon > >>>> 15/10/2020 14:04, Anatoly Burakov: > >>>>> +/** > >>>>> + * This function is not supported on ARM. > >>>>> + */ > >>>>> +static inline void > >>>>> +rte_power_monitor(const volatile void *p, const uint64_t > >>>> expected_value, > >>>>> + const uint64_t value_mask, const uint64_t > >>>>> tsc_timestamp, > >>>>> + const uint8_t data_sz) { > >>>>> + RTE_SET_USED(p); > >>>>> + RTE_SET_USED(expected_value); > >>>>> + RTE_SET_USED(value_mask); > >>>>> + RTE_SET_USED(tsc_timestamp); > >>>>> + RTE_SET_USED(data_sz); > >>>>> +} > >>>> Are you sure it cannot be partially supported with WFE instruction? > >>>> > >>> Armv8 WFE instruction can support monitoring of specific address for > >>> changes, > >>> but not monitoring of TSC timestamp. > >> So it is a partial support. > >> > >> We must try hard to unify architectures support > >> to avoid #ifdef everywhere. > >> > >> I don't agree with how are managed new instructions recently. > >> Please look further. > >> > > > > Hi Thomas, > > > > We believe this is ready for -rc1, can we discuss this with the > > technical board before the RC1 tag is applied? > > > > Hi Thomas, > By way of further follow-up, here are the reasons why we believe > it's ready for merge. > > There are 18 Acks for the 10 patches, with the two critical patches > getting 4 acks each. > These acks are from ARM, Marvell, IBM and Intel. > There have been 7 revisions, with quite a lot of discussion, and all > comments have been addressed and Ack'd. > From what I can see, the community are in agreement that this patch > should be merged. The problem is that I don't agree, and I feel you tried to avoid comments from others at the beginning. Now I don't want to spend more time on it before tagging -rc1. Next time, you'll make sure to Cc and reply everybody.