From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 72F9C5957 for ; Tue, 10 Nov 2015 15:04:09 +0100 (CET) Received: by wmdw130 with SMTP id w130so72304150wmd.0 for ; Tue, 10 Nov 2015 06:04:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=DFZu7/SePO1epA2hi+QqfmIiwjA0BEYaFGp17LKBQAU=; b=GmlgsWNoOW2itriv4sRTGg735dk4ORJ6NphaDHdzvd7VRlH7qGWCx2E6TAQYrS2zMT oIRvSFmBLMrzZ668SVmE60vpEzkOSHFsQI/bfYafXFF2cGHJVn3Fd9bQUtjoEgYOdFm4 r5cx92ZdsjpfcyzynEwZ9Y6hDQIhe8DyGq/YahpyYRo4N638eQ9bUsxBVcuudYAbPZwP SO2AtcG1GLqpCStPY0h/fHFEMBIIF5RSQOVe/z8FtWL7Ejgv4enVsgfs466tthF/lKvr KrgBr2buT++s0nH/AmRdhCnrrGdTBVeCd5u9bbEerz5yQktJFSUu9GZvrXBSstkpH7xD YlQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=DFZu7/SePO1epA2hi+QqfmIiwjA0BEYaFGp17LKBQAU=; b=YPRX9xNjE1zpqY9an9jMmidm5Qssn6FhZZFawUnOItR7IWPba2qWIxXFFMFv139fHw XYEDXhelFvZYCmvZhopDVTIkdBHXS4YwygA3a9juOr/vArXDJCFZPzuVcHMnnl3TU9eE CFhvV0CPpnCl4SCKvmex5xcJUzSZch3KWConyc6+vFMXsPvytqmeJl6WHcs+0PMDEsZa BoBQbJJZpFRTlWLtvk6pTRneDDeGThmJgMlYKefTs2ivQSGWo9950WF8fIgIjNSGWu8q DLdGlMtz74gdG5wco75E7OcnrajIwuQHzUuPQSwF1h9U17w5wbXzkKn/GDH4F0kr9Ubn z7zw== X-Gm-Message-State: ALoCoQmcLcbuKPFNy0xiSi9ObY7UgaqS09gw7c+T0ydkZKp8+UO7NeknrcfP/rUwtZmSgPo1tR5y X-Received: by 10.28.174.139 with SMTP id x133mr34721405wme.100.1447164249007; Tue, 10 Nov 2015 06:04:09 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id h7sm3713738wjz.7.2015.11.10.06.04.07 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Nov 2015 06:04:08 -0800 (PST) From: Thomas Monjalon To: Remy Horton Date: Tue, 10 Nov 2015 15:02:57 +0100 Message-ID: <2250304.OHJy4MJUpf@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1446723178-14876-2-git-send-email-remy.horton@intel.com> References: <1446723178-14876-1-git-send-email-remy.horton@intel.com> <1446723178-14876-2-git-send-email-remy.horton@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 1/3] rte: add keep alive functionality X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2015 14:04:09 -0000 Hi, 2015-11-05 11:32, Remy Horton: > +/** > + * @param *ptr_timer Triggering timer (unused) > + * @param *ptr_data Data pointer (keepalive structure) > + */ > +void rte_keepalive_dispatch_pings(void *ptr_timer, void *ptr_data); There is no description for this function. Why ptr_timer is unused? > +#ifdef KEEPALIVE_DEBUG_MSGS > +static void > +print_trace(const char *msg, struct rte_keepalive *keepcfg, int idx_core) > +{ > + printf("%sLast seen %" PRId64 "ms ago.\n", > + msg, > + ((rte_rdtsc() - keepcfg->last_alive[idx_core])*1000) > + / rte_get_tsc_hz() > + ); > +} > +#else > +static void > +print_trace(__attribute__((unused)) const char *msg, > + __attribute__((unused)) struct rte_keepalive *keepcfg, > + __attribute__((unused)) int idx_core) > +{ > +} > +#endif This function will never be tested and do not use rte_log. Please remove it and use the logging functions.