From: Thomas Monjalon <thomas@monjalon.net>
To: Beilei Xing <beilei.xing@intel.com>
Cc: dev@dpdk.org, wenzhuo.lu@intel.com, jingjing.wu@intel.com
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support bitmask for RSS and FDIR
Date: Mon, 06 Aug 2018 11:30:34 +0200 [thread overview]
Message-ID: <2252677.DSoj0ZM9iK@xps> (raw)
In-Reply-To: <1533534335-119817-1-git-send-email-beilei.xing@intel.com>
06/08/2018 07:45, Beilei Xing:
> This patch adds bitmask support for RSS, FDIR
> and FDIR flexible payload.
>
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
Flow director API is deprecated for almost 2 years:
http://git.dpdk.org/dpdk/commit/?id=7fdcde6
We asked several times to stop using it in i40e.
It has not been listened.
We have even accepted a workaround in flow_filtering example for i40e:
http://git.dpdk.org/dpdk/commit/?id=9a93446
We need to stop and move all to a common rte_flow API.
As a consequence, I will be against this patch.
next prev parent reply other threads:[~2018-08-06 9:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-06 5:45 Beilei Xing
2018-08-06 9:30 ` Thomas Monjalon [this message]
2018-08-10 2:31 ` Xing, Beilei
2018-08-10 8:58 ` Thomas Monjalon
2018-08-13 7:29 ` Xing, Beilei
2018-08-10 3:45 ` Jerin Jacob
2018-08-10 7:37 ` Xing, Beilei
2018-08-10 12:08 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2252677.DSoj0ZM9iK@xps \
--to=thomas@monjalon.net \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).