From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id D39181B46E
 for <dev@dpdk.org>; Mon,  6 Aug 2018 11:30:38 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 6577421C5F;
 Mon,  6 Aug 2018 05:30:37 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Mon, 06 Aug 2018 05:30:37 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=Ky9UCqIuHEZZXzmbI9CR7JfFSU
 t9QVFExLaown7+irk=; b=sLAawX97sZ9SElMKKT0Gfqh4Hov4bTobP6VJAUC4Xk
 4XcDQU99+j1cwbxoVUrYio20ylcVVKYqgyyoV8Pt8T0gU3bZQlThx+0yVUPnnL4/
 T9sJdiHc4ge3LZS1HF2I6rqVM2v66GqvnVmNzd/gDxH9+gTXkTu5hbHYORiz1z20
 s=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=Ky9UCq
 IuHEZZXzmbI9CR7JfFSUt9QVFExLaown7+irk=; b=NRaa+K7u62ghS3PmbzFcqJ
 s0Wsc1GXkAqpNDeEQLaRIlwK9BGWolyX/ru72NU1pY69Djf00DjklsFFoc15Dwsc
 lwgqsPvytdHVsXDNARaRbr5+Xr9s2PdFQAD4hWBOXBm5GQW9+HPEJJKuRGhKJDJa
 PN0HaWDZ1cGJJXTcoK9i0KuO/4O34Qf5BYK24Avhetxww5mTRB9AYrK7xv2n+k8W
 D0dt/Kxf+QBSdRUDvlpeTYwlp63L+rwkqRrNw9l65OypRA4RoL9Z1PAaywnzpqdT
 26+Jo4wJ8GbaNkY5nKkzmqHw01cKO2f9JGqO2hHUZd5FVjKkPhU6pD9/TSZhnvKA
 ==
X-ME-Proxy: <xmx:PBVoWzIvde6zICKRjv7ZFgt6Dga05DDPxsjusQvKk-ZvyQWYc7-ZfQ>
 <xmx:PBVoW8WSotaeIYi4JK99-AO-QdSDRCJvwyGWqLhXGT-Wtqcu3W6s2A>
 <xmx:PBVoW8l5aXeDQN-KcVPWYNQ4YSbh2-OZdxfoTLmRMAgznKwEc3-AJw>
 <xmx:PBVoWynBYrGJdMcCJLSZDfUJpUTwncTV-DHU4g56t-ZLB3Jcj2vrtw>
 <xmx:PBVoW8b0FhNWaiia9NxFnrkoVVVKkPsmO_KgrAOSRpQ-O5NdVuQe7A>
 <xmx:PRVoW9V--G-FootHkuY9cfJY62wlN5n7TaxBWorvny6tKZfGwQZ5Vg>
X-ME-Sender: <xms:PBVoWzRdNkvCnKHrz59QQx3_1apG5qOIYgTaGgJhnvFMGJxihg2k8A>
Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114])
 by mail.messagingengine.com (Postfix) with ESMTPA id 3E2FF10255;
 Mon,  6 Aug 2018 05:30:36 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Beilei Xing <beilei.xing@intel.com>
Cc: dev@dpdk.org, wenzhuo.lu@intel.com, jingjing.wu@intel.com
Date: Mon, 06 Aug 2018 11:30:34 +0200
Message-ID: <2252677.DSoj0ZM9iK@xps>
In-Reply-To: <1533534335-119817-1-git-send-email-beilei.xing@intel.com>
References: <1533534335-119817-1-git-send-email-beilei.xing@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support bitmask for RSS and FDIR
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Aug 2018 09:30:39 -0000

06/08/2018 07:45, Beilei Xing:
> This patch adds bitmask support for RSS, FDIR
> and FDIR flexible payload.
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>

Flow director API is deprecated for almost 2 years:
	http://git.dpdk.org/dpdk/commit/?id=7fdcde6
We asked several times to stop using it in i40e.
It has not been listened.
We have even accepted a workaround in flow_filtering example for i40e: 
	http://git.dpdk.org/dpdk/commit/?id=9a93446
We need to stop and move all to a common rte_flow API.

As a consequence, I will be against this patch.