Re: [dpdk-dev] [PATCH v4 18/23] ethdev: Helper to map to struct rte_pci_device

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2016-12-21 16:09, Jan Blunck:
> PCI drivers could use this helper instead of directly accessing fields of
> rte_eth_dev to map to rte_pci_device.
[...]
> +/**
> + * @internal
> + * Helper for drivers that need to convert from rte_eth_dev to rte_pci_device.
> + */
> +static inline struct rte_pci_device *__attribute__((always_inline))
> +rte_eth_dev_to_pci(struct rte_eth_dev *eth_dev)
> +{
> +	return eth_dev->pci_dev;
> +}

Why adding this function instead of just using DEV_PCI_DEV(eth_dev->device)?

I think we must try to avoid any PCI (or other bus) reference inside ethdev.h.