DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Jerin Jacob <jerinjacobk@gmail.com>
Subject: Re: [PATCH] build: remove deprecated meson functions
Date: Wed, 02 Feb 2022 18:47:35 +0100	[thread overview]
Message-ID: <2253479.n0HT0TaD9V@thomas> (raw)
In-Reply-To: <CALBAE1MPN2xd=x-un9X5v1GW7e9fioCqU9bLmDgkJ=P+ncYhVw@mail.gmail.com>

24/01/2022 19:12, Jerin Jacob:
> On Mon, Jan 24, 2022 at 11:20 PM Bruce Richardson
> <bruce.richardson@intel.com> wrote:
> >
> > Starting in meson 0.56, the functions meson.source_root() and
> > meson.build_root() are deprecated and to be replaced by the [more
> > descriptive] functions: project_source_root()/global_source_root() and
> > project_build_root()/global_build_root(). Unfortunately, these new
> > replacement functions were only added in 0.56 release too, so to use
> > them we would need version checks for old/new functions to remove the
> > deprecation warnings.
> >
> > However, the functions "current_build_dir()" and "current_source_dir()"
> > remain unaffected by all this, so we can bypass the versioning problem,
> > by saving off these values to "dpdk_source_root" and "dpdk_build_root"
> > in the top-level meson.build file
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Tested-by: Jerin Jacob <jerinj@marvell.com>

    Bugzilla ID: 926
    Cc: stable@dpdk.org

Applied, thanks.



  reply	other threads:[~2022-02-02 17:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-24 14:16 [Bug 926] meson: Use of Future-deprecated features bugzilla
2022-01-24 17:49 ` [PATCH] build: remove deprecated meson functions Bruce Richardson
2022-01-24 18:12   ` Jerin Jacob
2022-02-02 17:47     ` Thomas Monjalon [this message]
2022-03-15 16:44 ` [Bug 926] meson: Use of Future-deprecated features bugzilla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2253479.n0HT0TaD9V@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerinjacobk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).