From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8284543A77; Mon, 5 Feb 2024 13:39:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 51A9D402C8; Mon, 5 Feb 2024 13:39:25 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id BB5FD402BE for ; Mon, 5 Feb 2024 13:39:24 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.nyi.internal (Postfix) with ESMTP id 888E45C00BD; Mon, 5 Feb 2024 07:39:21 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 05 Feb 2024 07:39:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1707136761; x=1707223161; bh=uxvfcvgBjj/ITfx2nRJvAGkNwreYrHk0nNRnAGOv7aQ=; b= JoZwS6ucKbhlm6PLhu9xdsUP3YUYveYcw6tT4U+lNxwSKf/MFVClk4/F+D1GXRyP /AxbU1rM9EtQL4m2o8eTebb7grvH4OhPV6K/gq2odMlM9jDFwEHq50ayhL+GPVYZ JoTssdU34IVP7RJA/jcIYcWlCjdQ1AJEoik3tJkT6vXKkM/Nyiy5OCC1Cb0qy1Bk eKCEpeu8As4pN+sq61qrH0cExIt9rbdMosYkCfYGhzfNZwhtDiWQMXz1x43mUuNV rls8d1taBZ1Nq1JbT4cl/H8FmDknCf5PtnYTUocsuKz+UF+gO8H1iIIP3q9jAwNW Ua9mzxL7Xr5OIwCR9VmzBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1707136761; x= 1707223161; bh=uxvfcvgBjj/ITfx2nRJvAGkNwreYrHk0nNRnAGOv7aQ=; b=M rQKX0V4fk6lgvBT98nS+HacmoRwdNQsstkMCakNzKX/G4DtloyTj0/6Rov9Vqowl NMLFWcFFxXPqvCgyRNgnYrm+3Oj1y3iBpFKJkROgXTXGA5AqlBDwxygrDowGRZRt MiCSccWb8H2W/WkEK0UwWirRUFVRybaOOZrE9pk8DlJgQqqAy95+4VBzbYLb5TiX 0JFrq6O3k9jPSUjlHhzWgeqH01wc2EQuLb8cIYhVvEbjDya725Aah6zFj5YMv6yP 2Du+ivbDx0XaweNoNHbaylEvGcAXTIZjOo9H/V5ixcShwmP3GYe5Xk5+JS+uRgFO ndadOkSVT3V7uq3XC1k3Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrfedvtddggeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 5 Feb 2024 07:39:18 -0500 (EST) From: Thomas Monjalon To: Suanming Mou Cc: dev@dpdk.org, "ferruh.yigit@amd.com" , Ori Kam , Aman Singh , Yuying Zhang , Dariusz Sosnowski , Slava Ovsiienko , Matan Azrad , Andrew Rybchenko , "dev@dpdk.org" Subject: Re: [PATCH v6 1/3] ethdev: rename action modify field data structure Date: Mon, 05 Feb 2024 13:39:14 +0100 Message-ID: <2254754.iZASKD2KPV@thomas> In-Reply-To: References: <20231214031227.363911-1-suanmingm@nvidia.com> <3279240.44csPzL39Z@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > > --- a/lib/ethdev/rte_flow.h > > > +++ b/lib/ethdev/rte_flow.h > > > @@ -3894,6 +3894,7 @@ struct rte_flow_action_ethdev { > > > > > > /** > > > * Field IDs for MODIFY_FIELD action. > > > + * e.g. the packet field IDs used in RTE_FLOW_ACTION_TYPE_MODIFY_FIELD. > > > > Better to give the full name in the first line, so no need to add a second line of > > comment. > > So maybe " Field IDs for packet field, used by RTE_FLOW_ACTION_TYPE_MODIFY_FIELD."? Yes, or just "Packet header field IDs, used by RTE_FLOW_ACTION_TYPE_MODIFY_FIELD." > But when COMPARE item to be added. It will be " Field IDs for packet field, used by RTE_FLOW_ACTION_TYPE_MODIFY_FIELD and RTE_FLOW_ITEM_TYPE_COMPARE." And I assume that will still need a second line since it is too long. Yes no problem, I'm just trying to have something concise while being explicit and easy to read.