From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 1F4D9231C for ; Wed, 2 Dec 2015 17:58:20 +0100 (CET) Received: by wmec201 with SMTP id c201so263002866wme.0 for ; Wed, 02 Dec 2015 08:58:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=Gz5kdV+34vibG2vX7lx3MuP9aRUkWihT3huW5Uu3vbw=; b=ijpEHmzETIYbzHGYABv2ftqXXhqnhUZN9FXSD4+j5r30FFKJe9rH+tQhaexJ9lyCHM Y0d96Q8F+inSCFMzIeg6TadUM/XFoEYErxHONQWwxuXd6ENfbBfMXNnwBcHKNZ0F01Ty IwIh2eQpNlyt7hjdssnIrOWattLwNgTana5bRvizTZ4F10O9UqB5Ui49nvYepDvkL3gy Yof4RG7/QxU0iNfMTXNi7bNAofJooFxc7CfKHNbfYGiB6RqA9aw/Fur3MVKyl3XvaEYh NCHclsfNFcdLFsTyBcr8i1aGMFlTGIt69onmLU/fr/32d+hKYdAf+80AgAJn/0xqetCj qRTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=Gz5kdV+34vibG2vX7lx3MuP9aRUkWihT3huW5Uu3vbw=; b=mGH8Cp8D/m00CKksJbNUYnl8xa6WbViPIjreyJR7DDj2qfczh6jfCletMR/ijbTwSy 7dlFadAwWHeO7+YvWqcrybDyCAgULSdr44JGkY8a3aULwSgJuVMsabftVv0RzNPshQsB K4K0X5rBKMyGFLCZ4o+11O1f//4GRKSywW9stwL0gVJi24hx0SEPrcnwKmZa2jyfzd73 StqYM+kqPi7vkx2FcqQNnyI6PANKk43RCpD+lOmmsBwfzgFFP+eng7yH/daR9qWY6kyS 2fNbgl9v2UebkOGky2HjCxO3Eqy25QuQwJV/a1+ccUXv0movhrOt9f66FaEJm2QButcG NIiQ== X-Gm-Message-State: ALoCoQlVBMnMuVQwuBsPtHtBetfHPc7qLPJUnnehZExtOzDTbKFtPYuDMCn5c7CLfgGNvyO8Avd9 X-Received: by 10.28.59.131 with SMTP id i125mr47548695wma.75.1449075499971; Wed, 02 Dec 2015 08:58:19 -0800 (PST) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id v4sm3599331wjx.18.2015.12.02.08.58.19 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 02 Dec 2015 08:58:19 -0800 (PST) From: Thomas Monjalon To: Jerin Jacob Date: Wed, 02 Dec 2015 17:57:10 +0100 Message-ID: <2257776.TI734NhvVv@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20151202165302.GA2452@localhost.localdomain> References: <1448995276-9599-1-git-send-email-jianbo.liu@linaro.org> <2275492.7Tn0tJ2v06@xps13> <20151202165302.GA2452@localhost.localdomain> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 3/4] eal/arm: Enable lpm/table/pipeline libs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Dec 2015 16:58:20 -0000 2015-12-02 22:23, Jerin Jacob: > On Wed, Dec 02, 2015 at 05:40:13PM +0100, Thomas Monjalon wrote: > > 2015-12-02 20:04, Jerin Jacob: > > > On Wed, Dec 02, 2015 at 09:13:51PM +0800, Jianbo Liu wrote: > > > > On 2 December 2015 at 18:39, Jerin Jacob wrote: > > > > > AND they include "rte_lpm.h"(it internally includes rte_vect.h) > > > > > that lead to multiple definition and its not good. > > > > > > > > > But you will have similar issue since "typedef int32x4_t __m128i" > > > > appears in both your patch and this header file. > > > > > > I just tested it, it won't break, back to back "typedef int32x4_t __m128i" > > > is fine(unlike inline function). > > > > > > my intention to keep __m128i "as is" because changing the __m128i to rte_??? > > > something would break the ABI. > > > > Isn't it already broken in 2.2? > > Does it mean, You would like to have rte_128i(or similar) kind of > abstraction to represent 128bit SIMD variable in DPDK? If you are convinced that it is the best way to write a generic code, yes. I think the most important question is to know what is the best solution for performance and maintainability. The API/ABI questions will be considered after. Thanks for your involvement guys.