From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 440481B89F for ; Tue, 15 May 2018 16:03:07 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8AF4022586; Tue, 15 May 2018 10:03:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 15 May 2018 10:03:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=c5OwwpQvpxLniNXX6leezh1JZ5 lVtLFkTrZEQt5/GA4=; b=GKOnWpFb4J93ZchLzp4r/TydxlK9ZhkUd2lu5zdD0r vdiGIM6U94yll5q4ci2xdVwB/Y0p1NKbBPb6Rm29M602FlJlColgA3pWZJOij2eg R4o6wuXPk+E0U2kAqqDn6wnJf5vecf8toWHjjFOQMjc117Z5OiUbz6JDQsEX9YPA g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=c5Owwp QvpxLniNXX6leezh1JZ5lVtLFkTrZEQt5/GA4=; b=J2CgatGQT+qbCoM4xh5lrn He97LoxNaQBNOJbpnraelHmZiACpbTKIdXflJcAPlmvybfOokiU2kMPF7D7yxlJB ugB8aR8acO9yMv40vq62AmlmFrdZFoFPm079KptVm3qK94fWuCoCir4nR+WqQ4oL ka1LbZCOYMUf09k31fVN17qQO1vkJvHGVEOx4bKg9brR0qWS/g6fXCCbTAGMn8HF E9OyUcjcacpF85pFbrujUG2Zn0LZRw6X4rJrq9OcMXFt6OuPyTgtiSqXReGoxaGH QzRTW2XMNDOw40cowSamPWl+HwipaSFL2abm9yUK31V6fAlsGPuhYxqPQ3P0en5g == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D47CDE498C; Tue, 15 May 2018 10:03:02 -0400 (EDT) From: Thomas Monjalon To: "Burakov, Anatoly" Cc: dev@dpdk.org, Andrew Rybchenko , Bruce Richardson Date: Tue, 15 May 2018 16:03:01 +0200 Message-ID: <2259993.h8ZpUa3X5Z@xps> In-Reply-To: <6f35d96d-d5cd-f399-0af4-afd8ddaa050b@intel.com> References: <6f35d96d-d5cd-f399-0af4-afd8ddaa050b@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: move runtime dir creation after args parse X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 May 2018 14:03:07 -0000 15/05/2018 14:16, Burakov, Anatoly: > On 15-May-18 12:36 PM, Andrew Rybchenko wrote: > > On 05/15/2018 01:44 PM, Anatoly Burakov wrote: > >> The intention of the original code was to create runtime data > >> directory as early as possible, however it was moved too early, > >> before the arguments were parsed, resulting in --file-prefix > >> option essentially not working. > >> > >> Fix this by moving eal_create_runtime_dir() to after command > >> line arguments parsing. > >> > >> Fixes: 56236363b481 ("eal: add directory for runtime data") > >> > >> Reported-by: Andrew Rybchenko > >> > >> Signed-off-by: Anatoly Burakov > > > > Tested-by: Andrew Rybchenko > > > > I've tested it quickly and it solves the problem I observe. > > I suppose it is OK that the directory remains after application exit. > > > > Previously, all of the files that we were creating during runtime > remained, so having a directory where all the files are is better than > having a scattering of files :) > > Thanks for testing! Applied, thanks