From: Ilya Matveychikov <matvejchikov@gmail.com>
To: dev@dpdk.org
Subject: [dpdk-dev] A question about (poor) rte_ethdev internal rx/tx callbacks design
Date: Sat, 11 Nov 2017 21:18:45 +0400 [thread overview]
Message-ID: <2259E047-80C0-40AC-AAF4-F21617605508@gmail.com> (raw)
Folks,
Are you serious with it:
typedef uint16_t (*eth_rx_burst_t)(void *rxq,
struct rte_mbuf **rx_pkts,
uint16_t nb_pkts);
typedef uint16_t (*eth_tx_burst_t)(void *txq,
struct rte_mbuf **tx_pkts,
uint16_t nb_pkts);
I’m not surprised that every PMD stores port_id in every and each queue as having just the queue as an argument doesn’t allow to get the device. So the question is - why not to use something like:
typedef uint16_t (*eth_rx_burst_t)(void *dev, uint16_t queue_id,
struct rte_mbuf **rx_pkts,
uint16_t nb_pkts);
typedef uint16_t (*eth_tx_burst_t)(void *dev, uint16_t queue_id,
struct rte_mbuf **tx_pkts,
uint16_t nb_pkts);
Ilya.
next reply other threads:[~2017-11-11 17:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-11 17:18 Ilya Matveychikov [this message]
2017-11-12 2:43 ` Thomas Monjalon
2017-11-13 10:39 ` Adrien Mazarguil
2017-11-13 10:56 ` Ilya Matveychikov
2017-11-13 17:15 ` Adrien Mazarguil
2017-11-13 19:33 ` Ilya Matveychikov
2017-11-14 6:24 ` Andrew Rybchenko
2017-11-13 10:58 ` Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2259E047-80C0-40AC-AAF4-F21617605508@gmail.com \
--to=matvejchikov@gmail.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).