From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id A4996374; Wed, 24 Jan 2018 19:08:44 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0ADBE22790; Wed, 24 Jan 2018 13:08:44 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 24 Jan 2018 13:08:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=gbPb0OGnrDiAzqfdIhMyhipzHl qopjkM7p2kJXGliY0=; b=nWb5l0yc2UEwS+hKxTRoFaD/y7nDb2o997m51V+RZA EvNIGy1s7URo6TfNy2Td10Z/i0MxHuwMKvMAkZhIHEBF+QpZtp2H2RqcngBmVUwY AmTzt+uAarlbIVOQF/lyczMPQxvVfw/ulL5pzxwXklnE3deycPv2UTTaemn6oNW8 8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=gbPb0O GnrDiAzqfdIhMyhipzHlqopjkM7p2kJXGliY0=; b=dBjI7UkoH5Fc34VDblD40z yWz3n7yadyeKaOG+MiXq6FTXndsZXuv1mqgYL+w/32hOdlEFlvgHn7SI8Huczy5Y dE/rdRk9er8SHd83pLAoWgdBwkhw0iGVr245S4Sl455YPKXcNm7026bDHW9AuBMl d2fBhWgC8WVQnOhEffTd1ayRMEx0cypEq19JTgBLDx1ZpcSfyqG4gY15eqYuxaiY PsQFqsE6ycVgA8jWTouFJPx1Z/A0pTa1b2HASmx/XqIMne3LcCDpS/NNR4iFn6lx yJ4tPdx5Jg0b2mMdGr5AcHZyGjEIOY0/k0DUHNPOV7ljVZsLQKpjX5cBc//n2RJA == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AA858240F8; Wed, 24 Jan 2018 13:08:43 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger , Matan Azrad Cc: stable@dpdk.org, Ophir Munk , dev@dpdk.org, Olga Shern , Adrien Mazarguil Date: Wed, 24 Jan 2018 19:08:02 +0100 Message-ID: <2260225.RPhyHJgTVH@xps> In-Reply-To: <20180124073915.753a4764@xeon-e3> References: <1516792792-10119-1-git-send-email-ophirmu@mellanox.com> <1516803133-17529-1-git-send-email-ophirmu@mellanox.com> <20180124073915.753a4764@xeon-e3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/vdev_netvsc: fix build using C11 mode and pedantic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 18:08:44 -0000 24/01/2018 16:39, Stephen Hemminger: > On Wed, 24 Jan 2018 14:12:13 +0000 > Ophir Munk wrote: > > --- a/drivers/net/vdev_netvsc/Makefile > > +++ b/drivers/net/vdev_netvsc/Makefile > > @@ -12,7 +12,7 @@ EXPORT_MAP := rte_pmd_vdev_netvsc_version.map > > # Additional compilation flags. > > CFLAGS += -O3 > > CFLAGS += -g > > -CFLAGS += -std=c11 -pedantic -Wall -Wextra > > +CFLAGS += -Wall -Wextra > > CFLAGS += -D_XOPEN_SOURCE=600 > > CFLAGS += -D_BSD_SOURCE > > CFLAGS += -D_DEFAULT_SOURCE > > Why did this driver not use $(WERROR) like rest of DPDK drivers. It can be a separate patch. Matan?