From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id D6675234 for ; Fri, 30 Jan 2015 11:00:03 +0100 (CET) Received: by mail-wi0-f170.google.com with SMTP id bs8so1806540wib.1 for ; Fri, 30 Jan 2015 02:00:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=NaznEGAQ17dc567eKrD5p2h0iMKpiZGd4+GCmeE2HgQ=; b=b7aNlOximxtoWGDVwFhhxnv+JANLyP3D3ooHHqwCuZhSuf9mVowMumYVlMUeK57Q+Q 0y8OUlH2zQniYaJVAomNZk7sg5lD3L6P2DECIwuX0EL5VBpPrVfVXyrnYovfCjrpAtw7 d/UGOZkFwRfEE0XhVggjWslaFKAUyz2W/q1KwQihBmT+3TQAdJrNB6qVX5U2RH58PJQZ j/mzkc/RGp1ztstR8XJSprrMX9NHm6tPblkmNQm+hXAq9SgSoqCxIiQx6l+kijmNP8ia OyLabJ2IXofl3zWsxhVO5yKrGUowh6TsM0dPgtSukkqZcBBtBN3P4Xgj9zM4IjKSY6+D Ae0g== X-Gm-Message-State: ALoCoQlMz2VLaa5t9OUlfm1BxipzpYCfXI40kjiNRA0Ga3+low/+d+rW2OaKg3uvwcrvsV+z47Mu X-Received: by 10.194.110.69 with SMTP id hy5mr10199914wjb.121.1422612003635; Fri, 30 Jan 2015 02:00:03 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id bb2sm14166180wjc.43.2015.01.30.02.00.02 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Jan 2015 02:00:02 -0800 (PST) From: Thomas Monjalon To: Hemant Agrawal Date: Fri, 30 Jan 2015 10:59:37 +0100 Message-ID: <2263080.JfiolkiDdp@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <1520998.LI3zsdbzN8@xps13> References: <14060979121185-git-send-email-Hemant@freescale.com> <1791036.bZfV7z791K@xps13> <1520998.LI3zsdbzN8@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] kni: optimizing the rte_kni_rx_burst X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jan 2015 10:00:04 -0000 2014-11-26 22:20, Thomas Monjalon: > Ping > > 2014-11-11 23:58, Thomas Monjalon: > > Is there anyone interested in KNI to review this patch please? > > > > > > 2014-07-23 12:15, Hemant Agrawal: > > > The current implementation of rte_kni_rx_burst polls the fifo for buffers. > > > Irrespective of success or failure, it allocates the mbuf and try to put them into the alloc_q > > > if the buffers are not added to alloc_q, it frees them. > > > This waste lots of cpu cycles in allocating and freeing the buffers if alloc_q is full. > > > > > > The logic has been changed to: > > > 1. Initially allocand add buffer(burstsize) to alloc_q > > > 2. Add buffers to alloc_q only when you are pulling out the buffers. > > > > > > Signed-off-by: Hemant Agrawal >>From http://dpdk.org/ml/archives/dev/2015-January/011771.html, Jay said "The patch looks good from a DPDK 1.6r2 viewpoint. We saw the same behavior in our app and ended up avoiding it higher in the stack (in our code)." Reviewed-by: Jay Rolette -- Thomas