From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>, Paul Luse <paul.e.luse@intel.com>
Cc: dev@dpdk.org, Anatoly Burakov <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [PATCH] vdev: free reply.msgs memory for secondary process
Date: Thu, 25 Oct 2018 09:28:13 +0200 [thread overview]
Message-ID: <2263294.kZzMS7uBjY@xps> (raw)
In-Reply-To: <ae10c7df-bfe2-9525-f6b7-19a4a81b3789@intel.com>
27/09/2018 15:28, Ferruh Yigit:
> On 9/21/2018 5:25 PM, Paul Luse wrote:
> > From: paul luse <paul.e.luse@intel.com>
> >
> > This patch fixes an issue caught with ASAN where a vdev_scan()
> > to a secondary bus was failing to free some memory.
> >
> > Signed-off-by: paul luse <paul.e.luse@intel.com>
>
> (carry from Anatoly's ack from other thread)
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Adding Fixes: cdb068f031c6 ("bus/vdev: scan by multi-process channel")
Cc: stable@dpdk.org
> @Anatoly, what do you think about:
> diff --git a/lib/librte_eal/common/include/rte_eal.h
> b/lib/librte_eal/common/include/rte_eal.h
> index e114dcbdc..e1a554f5a 100644
> --- a/lib/librte_eal/common/include/rte_eal.h
> +++ b/lib/librte_eal/common/include/rte_eal.h
> @@ -309,7 +309,7 @@ rte_mp_sendmsg(struct rte_mp_msg *msg);
> * This function sends a request message to the peer process, and will
> * block until receiving reply message from the peer process.
> *
> - * @note The caller is responsible to free reply->replies.
> + * @note The caller is responsible to free reply->msgs.
> *
> * @param req
> * The req argument contains the customized request message.
Adding this change to the commit.
Fixes: 783b6e54971d ("eal: add synchronous multi-process communication")
All applied, thanks
next prev parent reply other threads:[~2018-10-25 7:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 16:25 Paul Luse
2018-09-21 16:53 ` Ferruh Yigit
2018-09-27 13:28 ` Ferruh Yigit
2018-10-25 7:28 ` Thomas Monjalon [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-09-20 23:29 paul luse
2018-09-21 11:07 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2263294.kZzMS7uBjY@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=paul.e.luse@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).