From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 40FFA4C95 for ; Thu, 25 Oct 2018 09:28:16 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 10F1EF57; Thu, 25 Oct 2018 03:28:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 25 Oct 2018 03:28:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=MpQgazuHUSa/BnKTepvDqD/UaqPRK0xr/RbfLcFmwJ0=; b=LG3+IWV8egTw sF4X+DM1OyVbBekyBNNUzwcr5bg1Gmmcu+PlBOSS6PPCNAB0C0sU8AEFVPQc2LqS dmBTkI0JS1X18kpNs3kdyy4cOy/QhhotRyRPt4ACUbNzwOAW8HskjSrEicedJW80 DxLJQpB8ywIz5XNR6Od51baiG8gAnyQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=MpQgazuHUSa/BnKTepvDqD/UaqPRK0xr/RbfLcFmw J0=; b=PZm3/eYZ/OIuTVIV9VW5NvfE1/R2OtnkNfdZ7O8YSAhHpCET/HhUtRKsZ OphYEcZdvsKZfkuuOO2MtU0L/3/2JwL0XXW0+PFgTs8FXs9C0NF92ELXXxbM2TAT qFODVnRGCp8EiyIrCScgZDxSlNhus6mOnd5n62rRCcNUR/Bh1TyQk/GGkosPFgAw NRlbphqFsoUv7+wU51F8v/W8FWFUaP4S0D/Q23jKLcfPmbXJ1AWOM3Uvi1Hu8IMj TefLNC8UeyIEtHMtBjuvZKeG3WhdeuaSuqK0/ua789JpyHSs0qUUmvAegh7Y9bPV fP1LbOsjmShiFGG2DTomiUrSzXoQA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 55370102EA; Thu, 25 Oct 2018 03:28:10 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit , Paul Luse Cc: dev@dpdk.org, Anatoly Burakov Date: Thu, 25 Oct 2018 09:28:13 +0200 Message-ID: <2263294.kZzMS7uBjY@xps> In-Reply-To: References: <20180921162557.48249-1-paul.e.luse@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] vdev: free reply.msgs memory for secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 07:28:16 -0000 27/09/2018 15:28, Ferruh Yigit: > On 9/21/2018 5:25 PM, Paul Luse wrote: > > From: paul luse > > > > This patch fixes an issue caught with ASAN where a vdev_scan() > > to a secondary bus was failing to free some memory. > > > > Signed-off-by: paul luse > > (carry from Anatoly's ack from other thread) > Acked-by: Anatoly Burakov > > Acked-by: Ferruh Yigit Adding Fixes: cdb068f031c6 ("bus/vdev: scan by multi-process channel") Cc: stable@dpdk.org > @Anatoly, what do you think about: > diff --git a/lib/librte_eal/common/include/rte_eal.h > b/lib/librte_eal/common/include/rte_eal.h > index e114dcbdc..e1a554f5a 100644 > --- a/lib/librte_eal/common/include/rte_eal.h > +++ b/lib/librte_eal/common/include/rte_eal.h > @@ -309,7 +309,7 @@ rte_mp_sendmsg(struct rte_mp_msg *msg); > * This function sends a request message to the peer process, and will > * block until receiving reply message from the peer process. > * > - * @note The caller is responsible to free reply->replies. > + * @note The caller is responsible to free reply->msgs. > * > * @param req > * The req argument contains the customized request message. Adding this change to the commit. Fixes: 783b6e54971d ("eal: add synchronous multi-process communication") All applied, thanks