From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 3D6411B168
 for <dev@dpdk.org>; Wed,  3 Jan 2018 09:17:19 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id BDF2F20BC4;
 Wed,  3 Jan 2018 03:17:18 -0500 (EST)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Wed, 03 Jan 2018 03:17:18 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=ad+jk2nQr44VP1N2vxaV0g9SdL
 H95MbUWplvMjf09Us=; b=A7QckFiyeJ1EM3l71ZlmZSfyHfeZmSA+TswwZMFpTk
 pZiOEvQNihWYdIqqW+LkV6THonqTarkP+7/CrhJPuXKH0UOU+r3PrRnAln5uc3Pb
 gfIvMUF2Tnq4iXjprbeu4H6tSVSL/Hbu4/Nwz5DgvyJNuNILJroKbVkxJwkSDZ5B
 M=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=ad+jk2
 nQr44VP1N2vxaV0g9SdLH95MbUWplvMjf09Us=; b=lPVGRanyZLYSPr89rvn5b5
 B10PT0psgm6UR9jHE/kbrQ4OBNSprXV9D3ckEcIyCxVhRSRYjb0gPO/ts+S5Oldi
 /zfQmSZezPuguJHT9eT9SoiYBORWIvyizD3ar813lytwjnjeXI0w2QW5tfN1rymM
 DHThOpoMEAN5cDtcs4p2UVNrRAQU9ZLcS11p1z+iW+Abse/7ZeSSIVaD3DnFpFid
 lNlsIhrCGJTJFGD2rADFCYkLfA3Al/NZo1HECD7NEGaJWzfnd8MkGIuvLM6/4ATj
 2oe5SBe0krYGjAZOEaWmgLlBJ9Mt93R1v/iqw2EelzdFYXSlPzPw7no9ymPwpz7g
 ==
X-ME-Sender: <xms:jpFMWpg87Avfj7yfr0owVy4HegXYM8ORKMhYk58b0Tba0kcijOsJVw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 755E57E351;
 Wed,  3 Jan 2018 03:17:18 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Neil Horman <nhorman@tuxdriver.com>, "Iremonger,
 Bernard" <bernard.iremonger@intel.com>
Cc: dev@dpdk.org, "Yigit, Ferruh" <ferruh.yigit@intel.com>
Date: Wed, 03 Jan 2018 09:17:01 +0100
Message-ID: <2264748.ymP9TsbnYi@xps>
In-Reply-To: <20180102122138.GA8096@hmswarspite.think-freely.org>
References: <20171128221302.15400-1-thomas@monjalon.net>
 <8CEF83825BEC744B83065625E567D7C24E06EEA4@IRSMSX108.ger.corp.intel.com>
 <20180102122138.GA8096@hmswarspite.think-freely.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v3 1/5] ethdev: remove useless parameter in
	callback process
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Jan 2018 08:17:19 -0000

02/01/2018 13:21, Neil Horman:
> On Tue, Jan 02, 2018 at 11:35:02AM +0000, Iremonger, Bernard wrote:
> > >  int _rte_eth_dev_callback_process(struct rte_eth_dev *dev,
> > > -		enum rte_eth_event_type event, void *cb_arg, void *ret_param);
> > > +		enum rte_eth_event_type event, void *ret_param);
> > 
> > As this is a change to the public API of librte_ether is a deprecation notice needed ?
> > This API is currently used by the test/test/virtual_pmd.c APP and may be used by other APP's in the field. 
> >  
> Agreed, it definately should go through the deprecation process

This function is used by drivers only, that's why there is an underscore
at the beginning of its name.
So it is not part of the regular ABI and does not need any deprecation
notice, in my opinion.