From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id DF1B01B827
 for <dev@dpdk.org>; Tue, 24 Oct 2017 22:48:38 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 8CE21209CA;
 Tue, 24 Oct 2017 16:48:38 -0400 (EDT)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Tue, 24 Oct 2017 16:48:38 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=ygTpQObUyoGe9nUta/X1Er2qFI
 8gEGo4QlGSTpiwLGc=; b=U3HNUXmreBV/w+wqLUHFzp7fzhgE8dJOvPekTVtIB5
 0widn7a+OI+V8ulWJHVwDRcGMOcveIYeqjCov7DLMXAPfJVLoz4Dg2qHVEqaajwI
 7G6ZjQkIjtED7/sSG0L7x+QymSt4R2cGR8VHwvAOWPhsNkyRTw/fkGdAGkFpjwhj
 Y=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=ygTpQO
 bUyoGe9nUta/X1Er2qFI8gEGo4QlGSTpiwLGc=; b=sDaM9SwzUd5NOq/CA++qK/
 v44jXk6EWj8nto2LKR9NppoxNkRf/qEaQLZL7Yd5uaxRg0PV6LF9Ofk4YWGRUIjO
 F6sCQm8MbpwGT+ZSFShyesf+Z9GmidtPWJif6YjVWhL/js6Wx2fHKWYIL6ghMaUj
 ASuzZohAKH81wcYFmlX43gAqrwzQlPAfjnFP77kmPwxxUFo5HCF591OUDlTVM5hF
 zMSaW6LCwQHgiFYIw3wZpGO9Qq9HTutlDMagokPVXSY3A8LXRjhsK5CpCGPt0K8j
 smXM9PVKvOtOznwNaWSGxOJFaKTLJ+jFx8DowmnaiFGgw2OtwQpvC/YzcANDrMSA
 ==
X-ME-Sender: <xms:JqfvWeeovMzNEszTMKu8KxB6CrhCk5Ffrn02Hfpiy4Tzj323NscZbA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 3C96D247AF;
 Tue, 24 Oct 2017 16:48:38 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Akhil Goyal <akhil.goyal@nxp.com>
Cc: dev@dpdk.org, declan.doherty@intel.com, pablo.de.lara.guarch@intel.com,
 hemant.agrawal@nxp.com, radu.nicolau@intel.com, borisp@mellanox.com,
 aviadye@mellanox.com, sandeep.malik@nxp.com, jerin.jacob@caviumnetworks.com,
 john.mcnamara@intel.com, konstantin.ananyev@intel.com, shahafs@mellanox.com,
 olivier.matz@6wind.com
Date: Tue, 24 Oct 2017 22:48:37 +0200
Message-ID: <2265201.zheMNP9zCB@xps>
In-Reply-To: <20171024141545.30837-9-akhil.goyal@nxp.com>
References: <20171014221734.15511-1-akhil.goyal@nxp.com>
 <20171024141545.30837-1-akhil.goyal@nxp.com>
 <20171024141545.30837-9-akhil.goyal@nxp.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v5 08/11] mk: add rte security into build
	system
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Oct 2017 20:48:39 -0000

Can you squash this patch with the one bringing the lib?

> +DEPDIRS-librte_cryptodev += librte_ether

I don't like this dependency.
Why is it needed?

> +DIRS-$(CONFIG_RTE_LIBRTE_SECURITY) += librte_security
> +DEPDIRS-librte_security := librte_eal librte_mempool librte_ring librte_mbuf
> +DEPDIRS-librte_security += librte_ether
> +DEPDIRS-librte_security += librte_cryptodev