From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 545BEA0548; Fri, 16 Apr 2021 14:58:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 01D2D141D91; Fri, 16 Apr 2021 14:58:51 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by mails.dpdk.org (Postfix) with ESMTP id 940CB141D87; Fri, 16 Apr 2021 14:58:49 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 61BA058050A; Fri, 16 Apr 2021 08:58:48 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 16 Apr 2021 08:58:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 9xGxkYHz5Sd7glN4/1yetXkY2iZH0f9+inY7bkCOYIU=; b=1Ea5Mve9WGPT7I4k FDGtQKO5F9Aj9QwuiBC9S/lC9TwPoZz4AnFo9QUn/lgpTLxxPSS9NP53u/uZUPwI ZENF5muZI8XouKynbLqYRiibTTGgp9qnmjfFX+DFmSy5DE9FC3CF29oRG5rZCKFP xffugX5LHzIXuVWCmvRDjqFE3bThrlRsEx24GSZ45cKDfspfW8Fjmigxf+xPv63B zq7sntMYIiBF9C5OoPtyzxn1obMBxZ8P5NSgBK9pQ/din/pUypmddc/jtjcl+/8c 72TIV1zx2cw5+sVVSYuFZLTzWI4fsk/KHTe5xEvf9ZO19V0GmYUkfCb4DDQgD9B8 nvEQOg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=9xGxkYHz5Sd7glN4/1yetXkY2iZH0f9+inY7bkCOY IU=; b=NANT5FXO5FM49K+g0+6ZyQzpbXyayL9to6RaZ1j3d1Au3gDGgTzY1PJHF JblNlKKGLmJgvYGB7PeZcw39RcInx+vvDznVmrvxT2jlSyNnrOJl0nr52SgXzuPa zeWUjfjpgFfGuzuutVGHQUP6jZE5bie9LSeRPJdIP1bNQzbUF4nvzkTKqHoYK1q7 WZObm7HQq64dQiWpO8xVuuUEg9xyXuZBYjstJph3QsjEZmDvSeZSgipnBr7ZhFAQ 4a7i/Vwjrl0W4a22zs3SZxgY1fv23JF5r5n6hv2ewY3yTeKdNS0CgvUxdXFSt6Fu Onqgqd8SiNVENnIDLytUD6G/Y+iVw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudelhedgheelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepvdeiuddvtefhueeuheetleelhfeivdejteehvdethfelueefhffg jeelfefhveegnecuffhomhgrihhnpeguphgukhdrohhrghdpthhhvgdrtghinecukfhppe ejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D0F171080057; Fri, 16 Apr 2021 08:58:44 -0400 (EDT) From: Thomas Monjalon To: Lincoln Lavoie Cc: Aaron Conole , David Marchand , dpdklab , Gaetan Rivet , dev , "Xueming(Steven) Li" , Asaf Penso , Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Gaetan Rivet , Anatoly Burakov , Ray Kinsella , Neil Horman , Ferruh Yigit , Andrew Rybchenko , Dodji Seketeli , ci@dpdk.org, Owen Hilyard Date: Fri, 16 Apr 2021 14:58:43 +0200 Message-ID: <2266462.BEuj6PQKus@thomas> In-Reply-To: References: <1608304614-13908-2-git-send-email-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdklab] Re: [PATCH v5 1/5] devargs: unify scratch buffer storage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/04/2021 14:43, Lincoln Lavoie: > All of the UNH ABI testing is moving info containers, so it can be run on > top of each OS, alongside the other compile and unit testing. This is > actually ready now, but hasn't been pushed live this week, because of the > backlog in the system because of the DTS failure. The additional compile > jobs are already online now, it's just ABI that hasn't been pushed live. > > This means the current ABI (what is reporting right now) is running on > 18.04 for x86 and 20.04 for aarch64. The aarch64 one will continue > forward, because we're not going to moving to emulated environments for > testing on that architecture. > > This has two implications, first, the scripts for running ABI (and the > other tests) become part of the container definition, and at the last > meeting we talked about moving those definitions into the dpdk-ci repo, > which I think makes sense. Second, there isn't an operating system to > "maintain" since it's what's inside the container images, which are > periodically rebuilt, but pretty much treated as ephemeral. Assuming the > container bases / distros have the updated libabigail version packaged with > them. No, the version packaged in the OS is not recent enough. Please check what is done in Travis and GitHub CI in the shell function install_libabigail(): https://git.dpdk.org/dpdk/tree/.ci/linux-build.sh#n22 > On Fri, Apr 16, 2021 at 8:32 AM Aaron Conole wrote: > > David Marchand writes: > > > > > On Tue, Apr 13, 2021 at 5:15 AM Xueming Li wrote: > > >> diff --git a/lib/librte_eal/include/rte_devargs.h > > b/lib/librte_eal/include/rte_devargs.h > > >> index 296f19324f..134b44a887 100644 > > >> --- a/lib/librte_eal/include/rte_devargs.h > > >> +++ b/lib/librte_eal/include/rte_devargs.h > > >> @@ -60,16 +60,16 @@ struct rte_devargs { > > >> /** Name of the device. */ > > >> char name[RTE_DEV_NAME_MAX_LEN]; > > >> RTE_STD_C11 > > >> - union { > > >> - /** Arguments string as given by user or "" for no argument. */ > > >> - char *args; > > >> + union { /**< driver-related part of device string. */ > > >> + const char *args; /**< legacy name. */ > > >> const char *drv_str; > > >> }; > > >> struct rte_bus *bus; /**< bus handle. */ > > >> struct rte_class *cls; /**< class handle. */ > > >> const char *bus_str; /**< bus-related part of device string. */ > > >> const char *cls_str; /**< class-related part of device string. > > */ > > >> - const char *data; /**< Device string storage. */ > > >> + char *data; > > >> + /**< Raw string including bus, class and driver arguments. */ > > >> }; > > >> > > >> /** > > > > > > - Flagging this patch for info and its impact on UNH jobs. > > > > > > This change is fine, but older libabigail versions could not deal with > > > such changes (anonymous union, changes of const fields). > > > This results in an ABI check failure in the UNH x86 job on Ubuntu > > > 18.04 (and for some people not using recent libabigail). > > > I can see the ARM job passes fine, so I suppose it is using a more > > > recent libabigail (running Ubuntu 20.04 maybe?). > > > > > > We either need to disable this x86 job or update its libabigail > > > package (maybe aligning with what we have for public CI which is > > > libabigail 1.8 manually compiled). > > > > > > > > > - For the longer term, what do you think of using/extending the .ci/ > > > scripts for use by UNH jobs? > > > > I think it would be great if we had some of the scripts shared as a > > common resource. That would also help us to look at fixes / changes > > when needed. > > > > > >