From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4204843D3E; Sun, 24 Mar 2024 23:12:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4B6040289; Sun, 24 Mar 2024 23:12:09 +0100 (CET) Received: from fhigh6-smtp.messagingengine.com (fhigh6-smtp.messagingengine.com [103.168.172.157]) by mails.dpdk.org (Postfix) with ESMTP id A5BB840281 for ; Sun, 24 Mar 2024 23:12:07 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 060A911400E2; Sun, 24 Mar 2024 18:12:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 24 Mar 2024 18:12:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1711318327; x=1711404727; bh=jtK45Zg1Xvx5aHN2+OKoHqGD0ky0F12e8og7PWAFjqg=; b= kjAm9SkH+HluKTV8e8A9etbJRUeEdjO2ljkKuUtjpCunxHNmGsgGBFYbMqSj7QWb QyWRLjKDzG+jXTWrc51aRKDZlYWnA+1twJooz+JATwqNxqdVxwG36A6lLc+y2mMM CxDjOfBLffufek+CsTW1+UjFQmRDt+kZnh3VtEWLLrZ9dkOBDpE0S394JLUqsnNF RY+H0qgdsv6GpouMKVu1nKeHRMViLQLT5imcSVjvoXCUVj4CEdq5JZK6nKz+/Urb fXX7URPw2YGnllFb9MDRh9XF3j68gdwO4kGyTww4KCSyhUDvmXa9C1Yvw6p6Yd8J /Xjm0yxLkqrb9anKXmIcMg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1711318327; x= 1711404727; bh=jtK45Zg1Xvx5aHN2+OKoHqGD0ky0F12e8og7PWAFjqg=; b=M vJPyU6Unn/kOfai2kvYg42OTjW/4xXJrxX2/9+7419S0+1Z3j3lNoe2mbSTtRzw6 LzfTgZjo08IlszGqhg9jIdiadjKV/m8Voz/KzJWUU8dBLJJVIkCAw2ZeGibvoEtW Nd1Fs18gomiEHiFKPnFMt7LHh60OsMz9cxPh8Y9vajlBZSqDFoN1TVFpckXu0CLc 4EAxrVMlfRSb7fCzJY7XKZBZiUqTrsvWQXS0qpb9TfjLWisXVtFJPoRUBvwnxUGM U1GDEMi6UXxSttBbHqnnBjl6p0d6zvoVnkAB7VVE5vFTxu9gD3uaO2JCzREEY+kQ 3On4xA9ZrwZ/VgruaiMaA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledruddtjedgudeiudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttdejnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnhepjeduveehieevuddutdevfffgtdegkeeuveejffejgedtgeeg kefgvdeugfefkeejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 24 Mar 2024 18:12:05 -0400 (EDT) From: Thomas Monjalon To: Yevgeny Kliteynik Cc: viacheslavo@nvidia.com, suanmingm@nvidia.com, Dariusz Sosnowski , Ori Kam , Matan Azrad , dev@dpdk.org, valex@nvidia.com, igozlan@nvidia.com, erezsh@nvidia.com Subject: Re: [PATCH 1/2] net/mlx5/hws: fix rule resize status check Date: Sun, 24 Mar 2024 23:12:02 +0100 Message-ID: <2266610.KTMopqUuYO@thomas> In-Reply-To: <20240321142414.1573453-1-kliteyn@nvidia.com> References: <20240321142414.1573453-1-kliteyn@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 21/03/2024 15:24, Yevgeny Kliteynik: > The check to detect if a rule is in resize was done incorrectly, > this can lead to an incorrect function call upon completion for > rules which are not in resize (move). > Since the resize_info is in a union we cannot rely only on the > pointer value but also need to make sure the matcher is in resize > process, this assures us the resize info is valid. > > Fixes: 762feceb8294 ("net/mlx5/hws: support resizable matchers") > > Signed-off-by: Yevgeny Kliteynik > Signed-off-by: Alex Vesker > Acked-by: Matan Azrad Series applied, thanks.