From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: drc@linux.vnet.ibm.com, Thinh Tran <thinhtr@linux.vnet.ibm.com>
Subject: Re: [dpdk-dev] [PATCH] test/autotest: checking for skipped or unsupported tests
Date: Sun, 24 May 2020 17:54:01 +0200 [thread overview]
Message-ID: <2266636.1OKvnQ6APU@thomas> (raw)
In-Reply-To: <20200302204132.121802-1-thinhtr@linux.vnet.ibm.com>
We are missing a review for this patch, please.
02/03/2020 21:41, Thinh Tran:
> - When running the dedault configuration of autotest of the make test
> it'd take 900 seconds (15 minutes) for the script TIMEOUT and marks
> Failed for a specific device test that is not supported on the
> system under test.
> - Adding the checking for those tests, print out as "Skipped [Not Run]"
> quickly return and continue for next test
>
> Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
> ---
> --- a/app/test/autotest_test_funcs.py
> +++ b/app/test/autotest_test_funcs.py
> @@ -12,13 +12,16 @@
> def default_autotest(child, test_name):
> child.sendline(test_name)
> result = child.expect(["Test OK", "Test Failed",
> - "Command not found", pexpect.TIMEOUT], timeout=900)
> + "Command not found", pexpect.TIMEOUT,
> + "Test Skipped"], timeout=900)
> if result == 1:
> return -1, "Fail"
> elif result == 2:
> return -1, "Fail [Not found]"
> elif result == 3:
> return -1, "Fail [Timeout]"
> + elif result == 4:
> + return 0, "Skipped [Not Run]"
> return 0, "Success"
next prev parent reply other threads:[~2020-05-24 15:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 20:41 Thinh Tran
2020-05-24 15:54 ` Thomas Monjalon [this message]
2020-06-02 16:53 ` David Christensen
2021-03-25 15:25 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2266636.1OKvnQ6APU@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=thinhtr@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).