From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id E92743B5 for ; Mon, 30 Jan 2017 10:58:35 +0100 (CET) Received: by mail-wm0-f53.google.com with SMTP id v77so39857050wmv.0 for ; Mon, 30 Jan 2017 01:58:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=jwOMWRT8TYCZ5Y89AZpnaIzdb1jXZem17e7LOe1SmgI=; b=VlU+EHb5IcMqfUpJrX1DH02QeCwuA32cxeshKuq8I+XfzRATL2aBwdilsFnUYfsQ5A GsZgwMznte1IZE7DNCoxmya+n8Q9i5+DmrIQZrWmFKAsxCkd44TsugjRpgnEhaSgck9p g3Yxh3qFGCwRvsWyxMfuCqzq6ZDbnxLqDuFIzDI2azQ2A8dnZt3p7xeirjdm00c0Lcrw ttI3Tf8i1Gri9/2WEXthnbUt6X4YYwN7+2NOiERh3TDpT5dt3EWTfGUzz0NdIuQ8hyrr HZw9yGR7ToLWHpd8gFtP+ByLqbIeI7osWu3CKG5WjynWkbAy34N4CiIr2did/yHHNm8A ZBmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=jwOMWRT8TYCZ5Y89AZpnaIzdb1jXZem17e7LOe1SmgI=; b=EMx6R5rAvwAqzjZjtlR4LOjHi5kGJf73VTZmgKmaPClBa4AMsHbp5sMnr+h8Pzn1go OAY77jg83UzvBLi1XxBoQ4Cue4A8D1rFdw1JVxTMwoIBwyGEqZ+nru5bPnH5A22mXpSv slk7qpVFXrjHFD98J9nsDIKgFBLLsIKLbtSk70eejYjXokfscMwDN8M8IF6HbHBZ3y8Q EC8jk9i2/7A2kbES17k85Vm63A1RTJG9fTpn7Csf9hzUgS+lRs3KTKYiCCdGi5iPeXiT Uxl8x6YZho8bzps96QhdUoVKihWi4YSk0Ln2G9GXK0bvW/Tl1PSBupKqYtTugiA2mdNK P8GQ== X-Gm-Message-State: AIkVDXK53U+7lDBBXFeq8BWV0+YUClSjAX9zlTUnXkoNaZlMydWRu4eedgnKD4lqT3juWxpu X-Received: by 10.28.184.133 with SMTP id i127mr12087568wmf.49.1485770315598; Mon, 30 Jan 2017 01:58:35 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id w204sm17856442wmd.17.2017.01.30.01.58.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Jan 2017 01:58:34 -0800 (PST) From: Thomas Monjalon To: Olivier Matz Cc: dev@dpdk.org, "De Lara Guarch, Pablo" , "Marohn, Byron" Date: Mon, 30 Jan 2017 10:58:34 +0100 Message-ID: <2268006.QGpdl6P310@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1485526997-31111-1-git-send-email-olivier.matz@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] efd: fix compilation by removing dep to libmath X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jan 2017 09:58:36 -0000 2017-01-27 14:45, De Lara Guarch, Pablo: > From: Olivier Matz [mailto:olivier.matz@6wind.com] > > > > When we compile the dpdk with: > > CONFIG_RTE_LIBRTE_EFD=y > > CONFIG_RTE_LIBRTE_NFP_PMD=n > > CONFIG_RTE_LIBRTE_THUNDERX_NICVF_PMD=n > > CONFIG_RTE_LIBRTE_SCHED=n > > CONFIG_RTE_LIBRTE_METER=n > > > > The linker gives the following error: > > lib/librte_efd.a(rte_efd.o): In function `rte_efd_create': > > lib/librte_efd/rte_efd.c:560: undefined reference to `log2' > > collect2: error: ld returned 1 exit status > > > > This is because the '-lm' is missing in mk/rte.app.mk. > > > > An alternative, which is proposed by this patch, is to use the compiler > > builtin rte_bsf32() to process log2 instead of the libmath log2() that > > requires to include math.h and link with -lm. > > > > Signed-off-by: Olivier Matz > > Acked-by: Pablo de Lara > > Nice catch, thanks! Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") Applied, thanks