From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 52C323237 for <dev@dpdk.org>; Tue, 26 Feb 2019 15:40:43 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CF8CA21FCE; Tue, 26 Feb 2019 09:40:42 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 26 Feb 2019 09:40:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=50vWfAYPsSSTh0x/hKRJ+QuxdHbylGm5UQhAi4f+AtM=; b=WABiZCOF6ZXj 1db0H++ZgVS9yocwCq5mogP3qgQ1MWO+mj7kE9WbAaDK524rjO+gm55WCKKL9SIp HxrP7Zr9RqQmdYgS5VTK7mVERZL6FAOZkVzNiywR4ww43kgFwmOSq3abzAD8W7mJ bSREl+h5EyCAUiTeVBai/nYht3mI6Ik= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=50vWfAYPsSSTh0x/hKRJ+QuxdHbylGm5UQhAi4f+A tM=; b=8HYs4S7dMq0XJMM2+tvAXFuV+Ffz1f+vWXXjM7uF9rUc3TJu+RUCc2Kcg qBrUltJT9OYS1pnFD+0dmbkhgJntJ5+DZnxxUNbGYNht1wk8byq449R3ii3ycfbo PcNT46hBRvnNjnnlCS5GjEVK3A4xWfnLK2VocU2/liJ/xDsPmThS7sRpyfkg2uaO DLfjPk26RR0SFb3/zh5xYDA34XA9dN/+6UsfL9dIindu/AMBfWA/bxhixxL0lrd1 ND5XNHpFINsjjx9V4S9fzO27kka4YD4q5BlvErBAHa6kLkbjvwAfCzW63epTg1YT +EboixxdSRnnxNneIbcUwyywfehag== X-ME-Sender: <xms:6k91XKHsk3IfIu4Zdsj9l3RVRIdFWR9XOLJqVzQCZXxlCp0JAXFqsA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrudelgdeilecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: <xmx:6k91XCNLqBYMBdOTT2IGNQJCZ0Ar46tUJXaY5sc9332bEPBRM4fiDw> <xmx:6k91XKaRAKZC0VRmVKfuu2lptB4cjxTQbXWLnJr_rg-feRuOOYnXmQ> <xmx:6k91XEd5ANaEQSZUOxt5noMuwozYLHbLUh65IfufNXLeVdOYzARa6Q> <xmx:6k91XIqyPzDkBZEsujUiuaQwhJ06XkasS9SqwPmQe6fVdxBW2F_iTQ> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 8A84BE455C; Tue, 26 Feb 2019 09:40:41 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: Bruce Richardson <bruce.richardson@intel.com> Cc: dev@dpdk.org Date: Tue, 26 Feb 2019 15:40:38 +0100 Message-ID: <2268995.D1hX1lYPB6@xps> In-Reply-To: <20190226121903.5499-1-bruce.richardson@intel.com> References: <20190125202642.66559-1-bruce.richardson@intel.com> <20190226121903.5499-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 0/5] consolidate testing apps to app dir X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 26 Feb 2019 14:40:43 -0000 26/02/2019 13:18, Bruce Richardson: > The apps for testing are split between the "test" and "app" directories, > with a not-very-clear distinction between the two (at least to my mind). > > Given how the apps are being built, the easiest path to having > cmdline_test, test-acl and test-pipeline build using meson is to > consolidate all these apps back into the app folder and use the logic > there. The bpf folder doesn't contain an actual application, but > rather example bpf code which can be loaded into testpmd. That is > possibly best moved to the examples folder, but I'm open to feedback > on the best place for it. > > With these changes, the "test" folder then becomes the location for > unit tests only. However, we can simplify things a little by moving > that too to the app folder, eliminating the need for the separate > "test-build" make target, and aligning the output folder for the > binary from "make test-build" with the source file location in app. > > --- > V3: * Renamed the cmdline_test subdirectory to test-cmdline as part of the > move. > V2: * Following some discussion with Thomas, moved the autotests to the > app folder too. > * Updated maintainers file appropriately in each patch. Applied, thanks